Skip to content

chore(image-cropper-web): fix changelog for release pipeline#2326

Merged
rahmanunver merged 1 commit into
mainfrom
chore/image-cropper-changelog
Jul 14, 2026
Merged

chore(image-cropper-web): fix changelog for release pipeline#2326
rahmanunver merged 1 commit into
mainfrom
chore/image-cropper-changelog

Conversation

@rahmanunver

Copy link
Copy Markdown
Contributor

No description provided.

@rahmanunver rahmanunver requested a review from a team as a code owner July 14, 2026 14:57
@github-actions

Copy link
Copy Markdown
Contributor

AI Code Review

⚠️ Approved with suggestions — low-severity items only, safe to merge


What was reviewed

File Change
packages/pluggableWidgets/image-cropper-web/CHANGELOG.md Moves the 1.0.0 release entry back under [Unreleased] and simplifies the description

Skipped (out of scope): no dist/, lockfiles, or generated files present.


Findings

⚠️ Low — Changelog entry lost behavioral detail

File: packages/pluggableWidgets/image-cropper-web/CHANGELOG.md line 11
Note: The original entry described concrete user-visible behavior (rectangular/circular viewport, zoom slider + wheel, live preview pane, PNG/JPEG output, replaces legacy ImageCrop). The replacement — "Initial release of Image cropper widget." — is too vague to be useful to app developers reading the changelog. AGENTS.md says changelogs should include widget behavior, not implementation details; the original text was behavioral. Consider restoring the description while keeping the entry under [Unreleased]:

## [Unreleased]

### Added

- Initial release. Crops a bound `EditableImageValue<WebImage>` attribute with rectangular or circular viewport, optional zoom (slider + wheel), live preview pane, and PNG/JPEG output. Replaces the legacy ImageCrop widget.

Positives

  • Moving the entry from a dated version heading back to [Unreleased] is the correct Keep a Changelog convention — version tags belong in a dedicated release PR, not in a feature/chore commit. This is the right fix.
  • Conventional commit title chore(image-cropper-web): fix changelog for release pipeline is clear and correctly scoped.

@rahmanunver rahmanunver reopened this Jul 14, 2026
@rahmanunver rahmanunver merged commit 910f459 into main Jul 14, 2026
28 of 33 checks passed
@rahmanunver rahmanunver deleted the chore/image-cropper-changelog branch July 14, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants