Skip to content

[WC-3223]: Rename Checkbox Radio Selector widget to Option Selector - #2403

Open
rahmanunver wants to merge 2 commits into
mainfrom
wc-3223/rename-option-selector
Open

[WC-3223]: Rename Checkbox Radio Selector widget to Option Selector#2403
rahmanunver wants to merge 2 commits into
mainfrom
wc-3223/rename-option-selector

Conversation

@rahmanunver

Copy link
Copy Markdown
Contributor

Closes WC-3223.

Renamed

Where From To
Studio Pro toolbox (<name>) Check box / radio selector Option Selector
Marketplace listing 245825 (appName) Checkbox Radio Selection Option Selector
package.json description, README, editor dropzones, design-time fallback captions, read-only style description old names Option Selector

<description> was empty and is now filled in — it mentions checkbox and radio button so toolbox and Marketplace search still find the widget.

CHANGELOG.md gets an [Unreleased] → Changed entry. No version bump.

Unchanged (keeps existing apps working)

Widget ID, package.xml, widgetName, mpk name, npm package name, folder, generated typings, and the widget-checkbox-radio-selection* CSS classes.

Verified: all 34 property keys and 141 XML attribute tokens are identical to main, git diff typings/ is empty, the runtime bundle contains no renamed strings, and the MPK filename plus every internal path are unchanged — so an upgrade is a drop-in replacement.

Note: widgets dropped in Studio Pro after this ships get auto-names like optionSelector1; existing instances keep theirs, so current e2e locators still match.

Build 7/7, unit tests 8/8.

@rahmanunver
rahmanunver requested a review from a team as a code owner August 27, 2026 15:14
@github-actions

This comment has been minimized.

@rahmanunver rahmanunver changed the title chore(checkbox-radio-selection-web): rename widget to Option Selector [WC-3223]: Rename Checkbox Radio Selector widget to Option Selector Aug 27, 2026
Renames the user-facing name only: XML <name>, marketplace appName, package
description, editor placeholders, README. Adds a toolbox description that keeps
mentioning checkbox and radio button for discoverability.

Widget ID, widgetName, mpk name, npm package, folder and CSS classes are
unchanged, so existing app configurations keep working.
@gjulivan
gjulivan force-pushed the wc-3223/rename-option-selector branch from b50f349 to 0bd9f78 Compare September 10, 2026 13:12
@github-actions

Copy link
Copy Markdown
Contributor

AI Code Review

✅ Approved — no issues found


What was reviewed

File Change
CHANGELOG.md Added [Unreleased] → Changed entry for the rename
README.md Retitled heading; updated usage step and package-name callout
package.json Updated description and marketplace.appName; identity fields frozen
src/CheckboxRadioSelection.xml <name> → "Option Selector"; <description> filled in; readOnlyStyle description updated
src/CheckboxRadioSelection.editorConfig.ts Three dropzone placeholder strings updated
src/helpers/utils.ts emptyStringFormat constant updated
src/helpers/Preview/PreviewCaptionsProvider.tsx emptyCaption updated
src/helpers/Association/utils.ts Comment-only update
src/helpers/Database/utils.ts Comment-only update
src/helpers/EnumBool/utils.ts Comment-only update
src/helpers/Static/utils.ts Comment-only update
src/ui/CheckboxRadioSelection.scss Banner comment updated
src/ui/CheckboxRadioSelectionPreview.scss Banner comment updated; "— editor preview" suffix added
openspec/changes/rename-option-selector/ New per-package OpenSpec artifacts (proposal, design, spec, tasks)

Skipped (out of scope): dist/, pnpm-lock.yaml, openspec/ content (not runtime code)

Note: gh pr checks required interactive approval in this environment — CI check status could not be confirmed automatically. The PR body states "Build 7/7, unit tests 8/8" which is consistent with the scope of this change (no runtime logic touched).


Positives

  • Identity contract held perfectly: widget ID, widgetName, mpkName, packagePath, marketplace.appNumber, CSS class prefix (widget-checkbox-radio-selection*), and generated typings filename are all untouched — exactly correct for a published widget rename.
  • The new <description> satisfies the discoverability requirement: it explicitly names both "checkbox" and "radio button", so toolbox search for either term still surfaces the widget under its new name.
  • OpenSpec artifacts are correctly scoped per-package (inside packages/pluggableWidgets/checkbox-radio-selection-web/openspec/) — respects the monorepo root restriction.
  • CHANGELOG entry is user-facing and accurate ("existing pages using it keep working without changes") — right level of detail for a changelog.
  • Design doc clearly articulates the two overlapping string sets (identity vs. presentation) and justifies every decision, including the accepted trade-off on the orphaned readOnlyStyle translation key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants