You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added Unreleased entries for the dep update and new plugin support
Skipped (out of scope): pnpm-lock.yaml (lockfile) — see critical finding below
Findings
🚨 Critical — Unresolved merge conflict in pnpm-lock.yaml
File:pnpm-lock.yaml lines ~378–385 and ~1914–1921 Problem: The lockfile contains raw <<<<<<< HEAD / ======= / >>>>>>> conflict markers. This means the file is broken — pnpm install will fail for any developer who checks out this branch, and CI installs will also fail. A corrupt lockfile blocks the entire repo from being built or tested. Fix: Resolve the conflict by choosing the correct version of @mendix/pluggable-widgets-tools (likely 11.13.0 from HEAD/main), then re-run pnpm install to regenerate a clean lockfile, and commit the result.
🔶 Medium — No tests covering the new subscript/superscript rendering
File:packages/pluggableWidgets/markdown-web/src/__tests__/Markdown.spec.tsx Problem: The existing test suite has no cases for the new ~subscript~ and ^superscript^ syntax that this PR enables. Because the plugins are registered on the module-level mdParser singleton, a test case would exercise real rendering. Without it, a future plugin misconfiguration (wrong call order, wrong import) would not be caught. Fix: Add test cases, for example:
⚠️ Low — Snapshot will silently pass after plugin addition without regeneration
File:packages/pluggableWidgets/markdown-web/src/__tests__/__snapshots__/Markdown.spec.tsx.snap Note: The existing snapshot test renders "Markdown viewer default value" which does not exercise the new plugins, so the snapshot has not changed. This is fine for now, but the snapshot test gives no signal about sub/sup rendering correctness — it only detects accidental structural regressions on plain-text input. The suggested test cases above (using specific DOM assertions) are preferable over relying on snapshots for new behaviour.
⚠️ Low — PR template sections are not filled in
File: PR description Note: All PR type checkboxes remain commented out, and the Description section is empty. This PR adds new user-visible functionality (sub/superscript support) and bumps a major dependency version — both warrant a short description of what was changed and why, plus guidance on what to test.
Positives
Correct use of MarkdownIt.PluginSimple type in the ambient declarations — avoids any and keeps the type-safe .use() call chain.
CHANGELOG entries follow the Keep a Changelog format correctly and are placed under [Unreleased] (not version-bumped), matching repo convention.
The module-level parser initialisation with .use(sub).use(sup) is idiomatic for markdown-it and avoids re-registering plugins on every render.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Description