Added MCU temp sensor to the companion#2897
Conversation
|
Yeah, great. |
…dev#2897) Apply yarda's changes from meshcore-dev#2897: report MCU temperature in self telemetry and contact telemetry responses, and fix NRF52Board::getMCUTemperature() to use sd_temp_get() when the SoftDevice is enabled (direct NRF_TEMP register access is SoftDevice-restricted). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CoUHCA3fM6g3uKdZYTpEzt
|
Ah, nice! I would recommend moving different way to obtain the temperature to different (static) functions for increased readability, because they differ significantly. But yes, if my companion is able to measure the temperature without extra sensor, I want to have it readable. |
It is consistent with the existing coding style, i.e. there is usually check for the softdev and two code paths in the function. |
|
Hello! Thanks for the PR. You are trying to merge changes into Also, you may need to rebase your changes on your local branch against Otherwise it will pull in a bunch of commits from |
|
Hmm, it seems I hit the wrong button in the UI :D But no problem, I will fix it. |
yarda
force-pushed
the
companion-add-mcu-temp-sensor
branch
from
16c629b to
15e259c
Compare
|
@liamcottle I hope it's OK now. |
4 participants
Fixes #2896