bump radiolib to 7.7.1#2912
Conversation
|
Hey, just FYI, haven't read your code changes yet; We are currently waiting for v7.7.2+ of RadioLib to be released, so we can merge in PR #2839 This PR might clash with an incoming PR from @oltaco which I believe bumps the repo to the latest git commit hash instead of a release version. Tagging him for awareness. |
|
Apart from the version bump the code is functionally the same, just using the newer patterns that radiolib will switch to starting version 8. |
this prepares us for radiolib release 8
295fa36 to
f132133
Compare
There was a problem hiding this comment.
Howdy! Thanks for the PR!
Would be nice to migrate to the new config object, but currently not a requirement.
I've just reviewed the code, but there seems to be a lot of issues.
So I assume this wasn't tested at all :)
Seems that variables for LDO and TCXO have been renamed, but not passed in at all with new config etc. So I guess in some cases, radios that expect TCXO voltage would not longer work, since it's not configured?
| "SPI": "*", | ||
| "Wire": "*", | ||
| "jgromes/RadioLib": "^7.6.0", | ||
| "jgromes/RadioLib": "^7.7.1", |
There was a problem hiding this comment.
not sure if we should tag against the git commit, as used in latest dev commits, hoping 7.7.2 or 7.8 will be out soon anyway.
|
I didn't check after updating from the 7.7.1 pin to the tag, will have a look. |
They're not locals - code should do the same as before. I think this will clear it up |
It includes some nice fixes. Full release notes here
Build here: https://mcimages.weebl.me?commitId=radiolib-7.7.1
Changed the init calls to use config instead, this prepares us for radiolib 8.0.0 removal of the now deprecated init methods.