Skip to content

TST: be stricter when checking wheel contents - #910

Merged
rgommers merged 1 commit into
mesonbuild:mainfrom
dnicolodi:tests-cleanup
Sep 29, 2026
Merged

rgommers merged 1 commit into
mesonbuild:mainfrom
dnicolodi:tests-cleanup

Conversation

@dnicolodi

Copy link
Copy Markdown
Member

There is no reason to allow uncertainty whether directory entries are present or not in the wheel files. For simplicity, directory entries are not added the wheel files, thus the tests require no adjustment.

There is no reason to allow uncertainty whether directory entries are
present or not in the wheel files.  For simplicity, directory entries
are not added the wheel files, thus the tests require no adjustment.

@rgommers rgommers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Checked where this came from, and it's a leftover from very early on when we were still using auditwheel directly (see commit message of commit 2d203c0).

@rgommers
rgommers merged commit 736144d into mesonbuild:main Sep 29, 2026
38 checks passed
@rgommers rgommers added the maintenance Regular code improvements that are not new features nor end-user-visible bugs label Sep 29, 2026
@rgommers rgommers added this to the v0.23.0 milestone Sep 29, 2026
@dnicolodi

Copy link
Copy Markdown
Member Author

Checked where this came from, and it's a leftover from very early on when we were still using auditwheel directly

Yes, I saw that. However, I would argue that the behaviour had to be deterministic back then too, thus filtering out directory entries was done just for minor convenience in writing the tests, rather than real changes between test runs. I didn't want to go into the details in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Regular code improvements that are not new features nor end-user-visible bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants