Repository navigation
Conversation
gantoreno
changed the title
|
The deployments were removed when this pull request closed. Reopening it deploys again at the same address. |
bpander
reviewed
Oct 5, 2026
|
|
||
| {% if jekyll.environment == "development" %} | ||
| <link href="/images/favicon-dev.svg" rel="shortcut icon" /> | ||
| <link href="/docs/images/favicon-dev.svg" rel="shortcut icon" /> |
Contributor
There was a problem hiding this comment.
The 4 images already existed in public/images so they should be removed from there.
Contributor
Author
There was a problem hiding this comment.
Addressed via Remove unused root-level icon duplicates
gantoreno
deleted the
gro-1070-restore-missing-favicon-and-apple-touch-icon-urls
branch
October 5, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GRO-1070
Related: https://github.com/metabase/metabase.github.io/pull/6628