Repository navigation
Fix mobile version picker - #1373
Draft
losrebellos wants to merge 10 commits into
Draft
losrebellos wants to merge 10 commits into
losrebellos wants to merge 10 commits into
Conversation
|
Commit 60bcf5c is live at https://docs-pr-1373-metaboat.vercel.app
Deployed to Vercel via GitHub Actions |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # src/components/chrome/TopBar.astro # src/layouts/NewDocsLayout.astro
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Mobile pages can lack a version picker, and responsive thresholds can briefly show duplicate pickers.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This pull request improves the docs version picker across mobile and desktop layouts.
Changes:
- Adds responsive picker styling and dropdown positioning.
- Hides the selector on
/docs/all. - Updates top-bar rendering and reformats the TOC icon.
| File | Summary |
|---|---|
src/layouts/NewDocsLayout.astro |
Controls selector visibility; mobile picker is missing on nested pages. |
src/components/chrome/VersionSelector.astro |
Updates responsive styling; breakpoint overlap can briefly show duplicate pickers. |
src/components/chrome/TopBar.astro |
Conditionally renders the selector; mobile hiding can remove the only picker. |
src/components/chrome/TocToggle.astro |
Reformats the TOC SVG markup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Correct media query to use min-width: 992px instead of 992.02px. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
losrebellos
marked this pull request as draft
October 6, 2026 13:04
losrebellos
marked this pull request as ready for review
October 6, 2026 16:45
losrebellos
marked this pull request as draft
October 6, 2026 16:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/metabase/issue/GRO-1054/docs-version-picker-has-no-background-on-mobile.
What's in
What's newbutton breakpoint updates fordisplayMobile
Desktop
Docs listing page
How to test