Add external application component type - #185
Merged
Merged
Conversation
vknabel
reviewed
Aug 28, 2026
| COMPONENT_TYPE_METAL_CONSOLE = 5 [(metalstack.api.v2.enum_string_value) = "metal-console"]; | ||
| // COMPONENT_TYPE_METAL_METRICS_EXPORTER is metal-metrics-exporter. | ||
| COMPONENT_TYPE_METAL_METRICS_EXPORTER = 6 [(metalstack.api.v2.enum_string_value) = "metal-metrics-exporter"]; | ||
| // COMPONENT_TYPE_EXTERNAL_APPLICATION is a external application. |
Contributor
There was a problem hiding this comment.
Suggested change
| // COMPONENT_TYPE_EXTERNAL_APPLICATION is a external application. | |
| // COMPONENT_TYPE_EXTERNAL_APPLICATION is an external application. |
Also requires regenerate.
majst01
force-pushed
the
external-application-component
branch
from
August 28, 2026 07:15
07bea65 to
6f5b8e6
Compare
majst01
force-pushed
the
external-application-component
branch
from
August 28, 2026 07:16
6f5b8e6 to
e0014ef
Compare
vknabel
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For applications which are connected to the metal-apiserver and not part of the core metal-stack ecosystem, it might be also worth enabling a component ping in these type of applications. This can now be done by specifying
external-applicationas component type and have the visibility of their connection.Also enable breaking change detection.
Used AI-Tools ✨