Skip to content

Add external application component type - #185

Merged
majst01 merged 1 commit into
mainfrom
external-application-component
Aug 28, 2026
Merged

Add external application component type#185
majst01 merged 1 commit into
mainfrom
external-application-component

Conversation

@majst01

@majst01 majst01 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Description

For applications which are connected to the metal-apiserver and not part of the core metal-stack ecosystem, it might be also worth enabling a component ping in these type of applications. This can now be done by specifying external-application as component type and have the visibility of their connection.

Also enable breaking change detection.

Used AI-Tools ✨

  • none used for generation

@majst01
majst01 requested a review from a team as a code owner August 28, 2026 07:09
@majst01 majst01 self-assigned this Aug 28, 2026
Comment thread proto/metalstack/api/v2/component.proto Outdated
COMPONENT_TYPE_METAL_CONSOLE = 5 [(metalstack.api.v2.enum_string_value) = "metal-console"];
// COMPONENT_TYPE_METAL_METRICS_EXPORTER is metal-metrics-exporter.
COMPONENT_TYPE_METAL_METRICS_EXPORTER = 6 [(metalstack.api.v2.enum_string_value) = "metal-metrics-exporter"];
// COMPONENT_TYPE_EXTERNAL_APPLICATION is a external application.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// COMPONENT_TYPE_EXTERNAL_APPLICATION is a external application.
// COMPONENT_TYPE_EXTERNAL_APPLICATION is an external application.

Also requires regenerate.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now :-)

@majst01
majst01 force-pushed the external-application-component branch from 07bea65 to 6f5b8e6 Compare August 28, 2026 07:15
@majst01
majst01 force-pushed the external-application-component branch from 6f5b8e6 to e0014ef Compare August 28, 2026 07:16
@majst01
majst01 merged commit 94c6613 into main Aug 28, 2026
8 checks passed
@majst01
majst01 deleted the external-application-component branch August 28, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants