Skip to content

Generate clients - #29

Merged
herber merged 1 commit into
mainfrom
generate-26-09-15
Sep 15, 2026
Merged

herber merged 1 commit into
mainfrom
generate-26-09-15

Conversation

@herber

@herber herber commented Sep 15, 2026 •

Copy link
Copy Markdown
Member

Note

Medium Risk
Large generated diff with breaking callback client shapes and removed endpoints; SDK integrators must migrate call sites even though runtime logic is mostly thin HTTP wrappers.

Overview
Regenerates the magnetar Python client under metorial/_generated/magnetar to match a newer API surface: new endpoint modules and type/mapper export lists, with matching updates across dashboard, management, and instance-scoped variants.

Callbacks (breaking for SDK callers): The integration-provider model replaces deployment-centric setup. callbacks create/update now take integration_id / integration_provider_id (optional name) and drop provider_deployment_id, destinations, triggers, and poll overrides; delete is documented as disabling callbacks on the provider. Nested clients for destinations, notifications, and callback-scoped events/instances are removed. Callback events and callback instances are new top-level read APIs (callback-events, callback-instances) with richer filters.

New product areas: A full chat stack (connections, instances, workspaces, chats, channels, messages, reactions, threads, DMs, typing, events). Consumer read APIs for agents, identity credentials, session connections, and tool calls. Skills merge requests (comments, events, resolve/perform/rollback), imports, fork syncs, and share. Organization event destinations/listeners, events, outposts (credentials/access), and webhook events. Documents edit-token fetch.

Note: Typed wrapper code such as _magnetar_sdk.py may still reference removed callback submodules unless updated in the same release.

Reviewed by Cursor Bugbot for commit df4e51b. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit df4e51b. Configure here.

request = MetorialRequest(
path=['chats', chat_id, 'dms']
)
return self._post(request).transform(mapDashboardInstanceChatsDmsOpenOutput.from_dict) No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DM open omits request body

High Severity

open POSTs with no body even though DashboardInstanceChatsDmsOpenBody is imported and the method is documented as opening a DM with one or more users. Callers cannot pass user IDs or other body fields, so the request cannot identify who the DM is for. The same gap is in the dashboard and management variants.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit df4e51b. Configure here.

@herber
herber merged commit df4e51b into main Sep 15, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant