Generate clients - #29
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit df4e51b. Configure here.
| request = MetorialRequest( | ||
| path=['chats', chat_id, 'dms'] | ||
| ) | ||
| return self._post(request).transform(mapDashboardInstanceChatsDmsOpenOutput.from_dict) No newline at end of file |
There was a problem hiding this comment.
DM open omits request body
High Severity
open POSTs with no body even though DashboardInstanceChatsDmsOpenBody is imported and the method is documented as opening a DM with one or more users. Callers cannot pass user IDs or other body fields, so the request cannot identify who the DM is for. The same gap is in the dashboard and management variants.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit df4e51b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Large generated diff with breaking callback client shapes and removed endpoints; SDK integrators must migrate call sites even though runtime logic is mostly thin HTTP wrappers.
Overview
Regenerates the magnetar Python client under
metorial/_generated/magnetarto match a newer API surface: new endpoint modules and type/mapper export lists, with matching updates across dashboard, management, and instance-scoped variants.Callbacks (breaking for SDK callers): The integration-provider model replaces deployment-centric setup.
callbackscreate/update now takeintegration_id/integration_provider_id(optionalname) and dropprovider_deployment_id, destinations, triggers, and poll overrides; delete is documented as disabling callbacks on the provider. Nested clients for destinations, notifications, and callback-scoped events/instances are removed. Callback events and callback instances are new top-level read APIs (callback-events,callback-instances) with richer filters.New product areas: A full chat stack (connections, instances, workspaces, chats, channels, messages, reactions, threads, DMs, typing, events). Consumer read APIs for agents, identity credentials, session connections, and tool calls. Skills merge requests (comments, events, resolve/perform/rollback), imports, fork syncs, and share. Organization event destinations/listeners, events, outposts (credentials/access), and webhook events. Documents edit-token fetch.
Note: Typed wrapper code such as
_magnetar_sdk.pymay still reference removed callback submodules unless updated in the same release.Reviewed by Cursor Bugbot for commit df4e51b. Bugbot is set up for automated code reviews on this repo. Configure here.