Repository navigation
Update test tooling to Vitest 5, jsdom 30 and Testing Library 16 - #1381
Merged
Merged
Conversation
Testing Library was listed in both dependencies and devDependencies; it is now dev only, with @testing-library/dom 10 added as react 16's peer. jest-dom 7 registers its matchers through @testing-library/jest-dom/vitest and no longer brings in @types/jest, so tsconfig takes vitest/globals. Testing Library cleans up after each test itself when globals are on.
microbit-matt-hillsdon
added
the
dependencies
|
Preview build will be at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vitest4 → 5,jsdom28 → 30@testing-library/react14 → 16 (with@testing-library/dom10 as its peer),@testing-library/jest-dom5 → 7,@testing-library/user-eventlatest 14dependenciesanddevDependencies; it's now dev onlysetupTests.tsimports@testing-library/jest-dom/vitestand drops the explicitcleanup, which Testing Library registers itself withglobals: true@types/jest, sotsconfig.jsontakesvitest/globalsPart of using jsdom 30 as the one test DOM across the Foundation's repos (microbit-foundation/microbit-org#333, microbit-foundation/ui#187).
Checked locally: 338 tests pass, as before; typecheck, lint and Prettier are clean.