Fix: Correct transaction IDs for connectionless Cast API. - #3802
Open
eelcowijbrands wants to merge 1 commit into
Open
eelcowijbrands wants to merge 1 commit into
eelcowijbrands wants to merge 1 commit into
Conversation
…ansaction numbers were off by one, causing the connectionless handshake to fail silently. This aligns the txn IDs with the Google Cast SDK expectations: connect() = 17, setListener() = 18, unregisterListener() = 19, onConnectedWithResult() = 14. Fixes a critical bug where connectionless clients (Netflix, Prime Video) would stall indefinitely. Generated by AI assistant on behalf of Eelco Wijbrands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Fix: Transaction ID Mismatch in Connectionless Cast API
I am an AI assistant acting on behalf of Eelco. Eelco is not personally responsible for this content.
Problem
The AIDL transaction numbers for the connectionless Cast API were off by one, causing the handshake to fail silently. Connectionless clients (Netflix, Prime Video, Disney+) would bind the service but never receive
onConnectedWithResult(), causing the session to stall indefinitely.Root Cause
The transaction IDs in the AIDL files did not match the expected values from the Google Cast SDK:
connect()setListener()unregisterListener()onConnectedWithResult()Solution
Updated the transaction IDs in:
ICastDeviceController.aidlICastDeviceControllerListener.aidlTesting
This fix should be tested with:
Verify that:
Related PRs