Repository navigation
Add Copilot review orchestration E2E coverage - #2414
Merged
Alexander Holstrup (aholstrup1) merged 2 commits intoOct 21, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Alexander Holstrup (aholstrup1)
requested a review
from a team
as a code owner
October 20, 2026 14:58
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Compatibility depends on the still-open prerequisite #2413, and live end-to-end orchestration remains unverified.
No open issues 🎉
What changed in this PR
Adds end-to-end coverage for AL-Go’s opt-in Copilot review orchestration and verifies that ordinary upgrades leave automatic reviews disabled.
Changes:
- Adds a Windows-only scenario checking first-attempt workflow success and the final review artifact, with bounded polling and no retries.
- Extends upgrade checks to accept absent review workflows or guarded, manual-only workflows.
| File | Description |
|---|---|
e2eTests/Test-AL-Go-Upgrade.ps1 |
Verifies review workflows remain inactive without opt-in. |
e2eTests/scenarios/CopilotCodeReview/runtest.ps1 |
Tests enabled review orchestration using one repository and PR. |
Review effort: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Maria Zhelezova (mazhelez)
approved these changes
Oct 21, 2026
Collaborator
Author
|
E2E test run here: https://github.com/microsoft/AL-Go/actions/runs/39556174256 |
Alexander Holstrup (aholstrup1)
enabled auto-merge (squash)
October 21, 2026 13:28
spetersenms
approved these changes
Oct 21, 2026
Alexander Holstrup (aholstrup1)
merged commit Oct 21, 2026
03ee88d
into
main
120 of 138 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❔What, Why & How
Add E2E coverage for Copilot review orchestration and verify that ordinary upgrades do not enable automatic review.
The new scenario creates one PTE repository, sets only
CodeReviewAgent.enabled = true, updates system files, and opens one PR with a small AL change. It checks that both review workflows succeed and the final review artifact exists. It uses default models and skills, does not inspect AI findings or comments, and skips the Linux invocation to avoid running the review twice. Waiting is bounded and does not rerun reviews.The existing upgrade test accepts absent review workflows or manual-only workflows with event guards, accounting for older updaters that copy template files directly. Run-count expectations are unchanged. This follows the behavior introduced by #2413 and should run against templates/actions containing that fix.
Local validation: 16 checks in a session-local mocked harness passed, PowerShell parsing and PSScriptAnalyzer passed, and
git diff --checkpassed. No live E2E or paid inference was run.Related to issue: N/A
✅ Checklist