Draft Proposal: Add targeted profiling feature - #4833
Draft
John (johnoliver) wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Java agent profiling based on targeted collection plans, allowing profiling to be triggered for specific cloud roles or role-qualified instances. It introduces new configuration classes and logic to handle these targeted plans, updates the alerting subsystem to support them, and refactors how manual triggers are tracked and executed. The changes also include enhancements to configuration APIs and internal tracking for executed triggers.
Targeted Profiling Support:
TargetedCollectionPlanConfigurationandTargetedInstanceConfigurationto define and validate targeted profiling plans for specific roles or instances. These classes provide methods to check if a plan applies to the current instance and if it is actionable based on expiration and selection criteria. [1] [2]AlertingConfigurationto optionally include aTargetedCollectionPlanConfiguration, and enhanced the API to determine if a profiling trigger is enabled for a given role or instance at a specific time. [1] [2]Alerting Subsystem Enhancements:
AlertingSubsystemto support targeted collection plan triggers, including new logic to evaluate and dispatch alerts for targeted plans, and to pass role and instance information throughout the subsystem. [1] [2] [3] [4] [5] [6]AlertingSubsystemConfigurationto encapsulate subsystem-level configuration, including role and instance identifiers.Manual Trigger Execution Tracking:
manualTriggersExecutedset with a newExecutedMonikerTrackerutility, which tracks executed triggers with retention and capacity limits to prevent duplicate profiling within a time window. [1] [2]Documentation and Test Updates:
CHANGELOG.mdto document the addition of Java agent support for targeted collection plans.For significant contributions please make sure you have completed the following items: