Skip to content

dataset(code-review): add reaction gold answers from BCApps PR 12207-neg-pr12207-20261020 - #977

Draft
Wenjie Fan (gggdttt) wants to merge 1 commit into
mainfrom
self-improvement/bcapps-12207-neg-pr12207-20261020-synthetic-eval
Draft

Wenjie Fan (gggdttt) wants to merge 1 commit into
mainfrom
self-improvement/bcapps-12207-neg-pr12207-20261020-synthetic-eval

Conversation

@gggdttt

@gggdttt Wenjie Fan (gggdttt) commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds code-review gold answers from explicit BCApps PR feedback.

Negative guards use exact source-file patches at immutable reviewed revisions, not invented synthetic code. Their targets are omitted from both expected and ignored comments; new negative-only entries have no expected findings.
Existing eligible gold answers are reused without changing their payloads.

Accepted findings

Rejected findings

Knowledge dependency

Validation

See the gate-owned offline evaluation section below.

Generated by the BC-ALAgentsInternal self-improvement workflow.

Offline evaluation: inconclusive

No knowledge change or no baseline false-positive reproduction. This pair cannot establish target suppression.

Preparation attempt 1: validated.

Selection: new. New: synthetic__breaking-access-unsupported-page-property-01. Reused (complete payloads): ``.

  • synthetic__breaking-access-unsupported-page-property-01 / false_positive_guard / [MCP] Prepare Data Query Tools for billing BCApps#12207 (comment): The review agent recommended adding 'Access = Internal;' to the new page object to narrow its exported surface, but Access is not a supported property on page objects in AL and the compiler rejects it with error AL0124 (documented supported object types for Access do not include Page). The developer reply confirms this makes the suggestion inapplicable, so the entry's expected_comments is empty and this guards against re-flagging the same unsupported-property suggestion on a page's Access property without encoding it as either an expected or ignored comment.
    Coverage references and outcome shapes are validated mechanically. Semantic equivalence, severity calibration and recommendation quality are NOT proved by these checks or a matching F1.

Common engine code: ecf8e31759d6ddd6d78e3a0b7836b40134368009; dataset SHA256: A99E41E40A33234EBBA8B4BE4DBC721D5AAC2204C16EFEB5BB7BA0EBA545E8DE.
Model: gpt-5.6-luna; judge: gpt-5.3-codex. Exact D: synthetic__breaking-access-unsupported-page-property-01.
Dataset base: 7c98b750c200d88ed0a81daaea5e71184a3af01b; candidate: f0b50eb0977fe67834c961d60d18b5688b6f0f98.

Arm Evaluation commit Engine pin Knowledge pin
baseline 6c5cdf9cc588fd2488cd86a2ff7d0c2a040e70ed edd46ef34e9b38d7cc2fc3e1c1c806ff8e476ab6 f820aa1e8515a6483b828d9a5b1c55112461b4d9
candidate c48f1d52b6373f8194225ee9cc69b3a794ff77b5 858748bdb9324c32dcf88c701192f7b23a189cff 616c617a1c7fad907ad2fc8f3d097958a80b68e1

Baseline

Run: https://github.com/microsoft/BC-Bench/actions/runs/39417558252; conclusion: success; wall clock: 6.8 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.

Entry Expected Generated Missed Unexpected F1 AI credits Agent seconds
synthetic__breaking-access-unsupported-page-property-01 0 0 0 0 1 unavailable 234.8432385

Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.

Aggregate metric Value
total 1
expected_comment_count 0
generated_comment_count 0
matched_comment_count 0
missed_comment_count 0
incorrect_comment_count 0
precision 1
recall 1
f1 1

Candidate

Run: https://github.com/microsoft/BC-Bench/actions/runs/39418386666; conclusion: success; wall clock: 6.3 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.

Entry Expected Generated Missed Unexpected F1 AI credits Agent seconds
synthetic__breaking-access-unsupported-page-property-01 0 0 0 0 1 unavailable 224.005767

Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.

Aggregate metric Value
total 1
expected_comment_count 0
generated_comment_count 0
matched_comment_count 0
missed_comment_count 0
incorrect_comment_count 0
precision 1
recall 1
f1 1

Missing telemetry is unavailable, not zero. Evaluation-only metrics exclude candidate generation and are not the full-cycle cost.
Human review must verify source-patch fidelity, gold correctness, and target attribution. No automatic merge or branch-protection claim is made.

Cycle usage and elapsed time (running, as of 2026-10-20T12:01:23.9054558+00:00)

Orchestrator work: 1005.066 seconds. This is not the completed GitHub workflow duration.

Stage / attempt Status / outcome Elapsed seconds
preflight / 1 completed / 5.966
quality_preparation / 1 completed / 48.613
gold_preparation / 1 completed / selected_new 131.126
evaluation_preparation / 1 completed / 24.239
baseline / 1 completed / success 413.291
candidate / 1 completed / success 381.107
gate_verdict / 1 completed / inconclusive 0.012
publication / 1 running / 0.022
receipts / 1 not_started / unavailable
quality_validation / 1 completed / 3.045
gold_attempt / 1 completed / validated 117.98
Measure Known subtotal Whole-cycle total Known / required components
ai_credit: aiCredits 56.47926 unavailable 2 / 6
premium_request: premiumRequests 40 unavailable 2 / 6
token: inputTokens 10611140 unavailable 4 / 6
token: outputTokens 100581 unavailable 4 / 6
token: totalTokens 10711721 unavailable 4 / 6

Subtotals are CLI/Bench-reported usage, not invoices. Missing values are not zero. Emitted-span coverage does not prove complete child/background billing; judge usage is not exported. Premium requests are not AI credits or currency.
Nested stage, agent and API durations are not added into cycle wall clock. Root queue/setup, telemetry export, artifact upload and later dashboard publication are excluded.
PR evidence is an as-of snapshot before publication completes. Final-for-orchestrator metrics are emitted to self-improvement-cycle.json in the root self-improvement-feedback artifact and its Actions summary when persistence succeeds; a running checkpoint is not final evidence.
Root run: https://github.com/microsoft/BC-ALAgentsInternal/actions/runs/39417084712/attempts/1

@github-code-quality

Copy link
Copy Markdown
Contributor

Code coverage overview

Languages: Python

Python / code-coverage/pytest

main 7c98b75 self-improvement/bca... f0b50eb +/-
88% 88% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant