Repository navigation
dataset(code-review): add reaction gold answers from BCApps PR 11904-neg-pr11904-20261020 - #978
Draft
Wenjie Fan (gggdttt) wants to merge 1 commit into
Conversation
…neg-pr11904-20261020
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds code-review gold answers from explicit BCApps PR feedback.
Negative guards use exact source-file patches at immutable reviewed revisions, not invented synthetic code. Their targets are omitted from both expected and ignored comments; new negative-only entries have no expected findings.
Existing eligible gold answers are reused without changing their payloads.
Accepted findings
Rejected findings
Knowledge dependency
Validation
See the gate-owned offline evaluation section below.
Generated by the BC-ALAgentsInternal self-improvement workflow.
Offline evaluation: regression
Candidate correctness failed: unexpected or missed findings remain. Existing ignored gold comments retain their neutral scoring semantics.
Preparation attempt 1: validated.
Selection: new. New:
synthetic__performance-setloadfields-returned-record-param-01. Reused (complete payloads): ``.synthetic__performance-setloadfields-returned-record-param-01/false_positive_guard/ Bug 649862: [Subcontracting] Restore Get Receipt Lines for subcontracting receipts BCApps#11904 (comment): The flagged FindSet iteratesItemLedgerEntry, avarparameter of IsFullTrackedOutputSetSupported that the caller (CopyTrackedSubcontractingOutputToSeparateInvoice) keeps using after the call: CopyItemLedgerEntriesUpToQuantity executesTempItemLedgerEntry := ItemLedgerEntryto buffer the whole entry for later item-tracking-specification creation, so narrowing the load to the loop's own six fields (as flagged) would drop fields that buffer still needs, exactly the caller-and-helpers caveat the cited article already states. The developer's negative feedback rejects the suggestion for this reason, not because SetLoadFields is unwanted in general, so the guard is scoped to this var-parameter/round-trip-return case and does not claim SetLoadFields is never applicable to Item Ledger Entry reads elsewhere in the file.Coverage references and outcome shapes are validated mechanically. Semantic equivalence, severity calibration and recommendation quality are NOT proved by these checks or a matching F1.
Common engine code:
ecf8e31759d6ddd6d78e3a0b7836b40134368009; dataset SHA256:B92EB57C2A7B0E5B9DF49B03C99832457D4B428AFCB79FBBD1FF6402AEE546AE.Model:
gpt-5.6-luna; judge:gpt-5.3-codex. Exact D:synthetic__performance-setloadfields-returned-record-param-01.Dataset base:
7c98b750c200d88ed0a81daaea5e71184a3af01b; candidate:5aa676188af88dea157fb8357e36753822fd42aa.8c186bd46b6276dce4d75ad8217a472a95d70cdbedd46ef34e9b38d7cc2fc3e1c1c806ff8e476ab6f820aa1e8515a6483b828d9a5b1c55112461b4d983724e328337f1e34852a76d7e3eff185642c0c178d3b7d42f1e3b5dbaf0d177ebbe84fc7560324e72c4164f7110b0f1539085b6113969357f263ad6Baseline
Run: https://github.com/microsoft/BC-Bench/actions/runs/39421008242; conclusion: success; wall clock: 7.7 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.
synthetic__performance-setloadfields-returned-record-param-01Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.
Candidate
Run: https://github.com/microsoft/BC-Bench/actions/runs/39421990554; conclusion: success; wall clock: 7.5 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.
synthetic__performance-setloadfields-returned-record-param-01Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.
Missing telemetry is unavailable, not zero. Evaluation-only metrics exclude candidate generation and are not the full-cycle cost.
Human review must verify source-patch fidelity, gold correctness, and target attribution. No automatic merge or branch-protection claim is made.
Cycle usage and elapsed time (running, as of 2026-10-20T12:32:13.7416654+00:00)
Orchestrator work: 1521.172 seconds. This is not the completed GitHub workflow duration.
Subtotals are CLI/Bench-reported usage, not invoices. Missing values are not zero. Emitted-span coverage does not prove complete child/background billing; judge usage is not exported. Premium requests are not AI credits or currency.
Nested stage, agent and API durations are not added into cycle wall clock. Root queue/setup, telemetry export, artifact upload and later dashboard publication are excluded.
PR evidence is an as-of snapshot before publication completes. Final-for-orchestrator metrics are emitted to self-improvement-cycle.json in the root self-improvement-feedback artifact and its Actions summary when persistence succeeds; a running checkpoint is not final evidence.
Root run: https://github.com/microsoft/BC-ALAgentsInternal/actions/runs/39419765947/attempts/1