Skip to content

dataset(code-review): add reaction gold answers from BCApps PR 11904-neg-pr11904-20261020 - #978

Draft
Wenjie Fan (gggdttt) wants to merge 1 commit into
mainfrom
self-improvement/bcapps-11904-neg-pr11904-20261020-synthetic-eval
Draft

Wenjie Fan (gggdttt) wants to merge 1 commit into
mainfrom
self-improvement/bcapps-11904-neg-pr11904-20261020-synthetic-eval

Conversation

@gggdttt

@gggdttt Wenjie Fan (gggdttt) commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds code-review gold answers from explicit BCApps PR feedback.

Negative guards use exact source-file patches at immutable reviewed revisions, not invented synthetic code. Their targets are omitted from both expected and ignored comments; new negative-only entries have no expected findings.
Existing eligible gold answers are reused without changing their payloads.

Accepted findings

Rejected findings

Knowledge dependency

Validation

See the gate-owned offline evaluation section below.

Generated by the BC-ALAgentsInternal self-improvement workflow.

Offline evaluation: regression

Candidate correctness failed: unexpected or missed findings remain. Existing ignored gold comments retain their neutral scoring semantics.

Preparation attempt 1: validated.

Selection: new. New: synthetic__performance-setloadfields-returned-record-param-01. Reused (complete payloads): ``.

  • synthetic__performance-setloadfields-returned-record-param-01 / false_positive_guard / Bug 649862: [Subcontracting] Restore Get Receipt Lines for subcontracting receipts BCApps#11904 (comment): The flagged FindSet iterates ItemLedgerEntry, a var parameter of IsFullTrackedOutputSetSupported that the caller (CopyTrackedSubcontractingOutputToSeparateInvoice) keeps using after the call: CopyItemLedgerEntriesUpToQuantity executes TempItemLedgerEntry := ItemLedgerEntry to buffer the whole entry for later item-tracking-specification creation, so narrowing the load to the loop's own six fields (as flagged) would drop fields that buffer still needs, exactly the caller-and-helpers caveat the cited article already states. The developer's negative feedback rejects the suggestion for this reason, not because SetLoadFields is unwanted in general, so the guard is scoped to this var-parameter/round-trip-return case and does not claim SetLoadFields is never applicable to Item Ledger Entry reads elsewhere in the file.
    Coverage references and outcome shapes are validated mechanically. Semantic equivalence, severity calibration and recommendation quality are NOT proved by these checks or a matching F1.

Common engine code: ecf8e31759d6ddd6d78e3a0b7836b40134368009; dataset SHA256: B92EB57C2A7B0E5B9DF49B03C99832457D4B428AFCB79FBBD1FF6402AEE546AE.
Model: gpt-5.6-luna; judge: gpt-5.3-codex. Exact D: synthetic__performance-setloadfields-returned-record-param-01.
Dataset base: 7c98b750c200d88ed0a81daaea5e71184a3af01b; candidate: 5aa676188af88dea157fb8357e36753822fd42aa.

Arm Evaluation commit Engine pin Knowledge pin
baseline 8c186bd46b6276dce4d75ad8217a472a95d70cdb edd46ef34e9b38d7cc2fc3e1c1c806ff8e476ab6 f820aa1e8515a6483b828d9a5b1c55112461b4d9
candidate 83724e328337f1e34852a76d7e3eff185642c0c1 78d3b7d42f1e3b5dbaf0d177ebbe84fc7560324e 72c4164f7110b0f1539085b6113969357f263ad6

Baseline

Run: https://github.com/microsoft/BC-Bench/actions/runs/39421008242; conclusion: success; wall clock: 7.7 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.

Entry Expected Generated Missed Unexpected F1 AI credits Agent seconds
synthetic__performance-setloadfields-returned-record-param-01 0 6 0 6 0 unavailable 311.3163567

Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.

Aggregate metric Value
total 1
expected_comment_count 0
generated_comment_count 6
matched_comment_count 0
missed_comment_count 0
incorrect_comment_count 6
precision 0
recall 1
f1 0

Candidate

Run: https://github.com/microsoft/BC-Bench/actions/runs/39421990554; conclusion: success; wall clock: 7.5 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.

Entry Expected Generated Missed Unexpected F1 AI credits Agent seconds
synthetic__performance-setloadfields-returned-record-param-01 0 3 0 3 0 unavailable 312.4675923

Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.

Aggregate metric Value
total 1
expected_comment_count 0
generated_comment_count 3
matched_comment_count 0
missed_comment_count 0
incorrect_comment_count 3
precision 0
recall 1
f1 0

Missing telemetry is unavailable, not zero. Evaluation-only metrics exclude candidate generation and are not the full-cycle cost.
Human review must verify source-patch fidelity, gold correctness, and target attribution. No automatic merge or branch-protection claim is made.

Cycle usage and elapsed time (running, as of 2026-10-20T12:32:13.7416654+00:00)

Orchestrator work: 1521.172 seconds. This is not the completed GitHub workflow duration.

Stage / attempt Status / outcome Elapsed seconds
preflight / 1 completed / 7.95
quality_preparation / 1 completed / 137.727
gold_preparation / 1 completed / selected_new 398.462
evaluation_preparation / 1 completed / 26.931
baseline / 1 completed / success 475.073
candidate / 1 completed / success 474.307
gate_verdict / 1 completed / regression 0.008
publication / 1 running / 0.021
receipts / 1 not_started / unavailable
quality_validation / 1 completed / 3.147
gold_attempt / 1 completed / validated 381.983
Measure Known subtotal Whole-cycle total Known / required components
ai_credit: aiCredits 196.15918 unavailable 2 / 6
premium_request: premiumRequests 74 unavailable 2 / 6
token: inputTokens 18318084 unavailable 4 / 6
token: outputTokens 220236 unavailable 4 / 6
token: totalTokens 18538320 unavailable 4 / 6

Subtotals are CLI/Bench-reported usage, not invoices. Missing values are not zero. Emitted-span coverage does not prove complete child/background billing; judge usage is not exported. Premium requests are not AI credits or currency.
Nested stage, agent and API durations are not added into cycle wall clock. Root queue/setup, telemetry export, artifact upload and later dashboard publication are excluded.
PR evidence is an as-of snapshot before publication completes. Final-for-orchestrator metrics are emitted to self-improvement-cycle.json in the root self-improvement-feedback artifact and its Actions summary when persistence succeeds; a running checkpoint is not final evidence.
Root run: https://github.com/microsoft/BC-ALAgentsInternal/actions/runs/39419765947/attempts/1

@github-code-quality

Copy link
Copy Markdown
Contributor

Code coverage overview

Languages: Python

Python / code-coverage/pytest

main 7c98b75 self-improvement/bca... 5aa6761 +/-
88% 88% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant