Skip to content

dataset(code-review): add reaction gold answers from BCApps PR 12261-neg-pr12261-20261020 - #980

Draft
Wenjie Fan (gggdttt) wants to merge 1 commit into
mainfrom
self-improvement/bcapps-12261-neg-pr12261-20261020-synthetic-eval
Draft

Wenjie Fan (gggdttt) wants to merge 1 commit into
mainfrom
self-improvement/bcapps-12261-neg-pr12261-20261020-synthetic-eval

Conversation

@gggdttt

@gggdttt Wenjie Fan (gggdttt) commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds code-review gold answers from explicit BCApps PR feedback.

Negative guards use exact source-file patches at immutable reviewed revisions, not invented synthetic code. Their targets are omitted from both expected and ignored comments; new negative-only entries have no expected findings.
Existing eligible gold answers are reused without changing their payloads.

Accepted findings

Rejected findings

Knowledge dependency

Validation

See the gate-owned offline evaluation section below.

Generated by the BC-ALAgentsInternal self-improvement workflow.

Offline evaluation: regression

Candidate correctness failed: unexpected or missed findings remain. Existing ignored gold comments retain their neutral scoring semantics.

Preparation attempt 1: invalid_selection. A nonempty version 1 selection.entries array is required; empty candidates or prose are not a selection.

Preparation attempt 2: validated.

Selection: new. New: synthetic__sec-internal-reschedule-job-01. Reused (complete payloads): ``.

  • synthetic__sec-internal-reschedule-job-01 / false_positive_guard / Stop repeated rescheduling of Dataverse synch jobs on bulk changes BCApps#12261 (comment): The reviewed source snapshot shows the only call to the new internal RescheduleJobQueueEntriesForTable procedure is the pre-existing caller that already executes 'if not UserCanRescheduleJob() then exit;' immediately before invoking it, so the authorization boundary for this operation is unchanged and still enforced at its one reachable call site. The bot's 'Access=Internal is not a security boundary' critique is correct as a general principle but misapplied here since no new unauthorized path was introduced; the developer's rejection ('Internal procedure') matches this. expected_comments is empty and no finding is asserted in this range; limitation: this guard does not generalize to internal helpers with multiple or future call sites that might skip the check.
    Coverage references and outcome shapes are validated mechanically. Semantic equivalence, severity calibration and recommendation quality are NOT proved by these checks or a matching F1.

Common engine code: ecf8e31759d6ddd6d78e3a0b7836b40134368009; dataset SHA256: 4BB90627EA444D4C36EF5A1103738A6727AA48D8CD6F08398E0CD8EF6204B754.
Model: gpt-5.6-luna; judge: gpt-5.3-codex. Exact D: synthetic__sec-internal-reschedule-job-01.
Dataset base: 7c98b750c200d88ed0a81daaea5e71184a3af01b; candidate: ea00574bc103b7002f2b3413bea080a9b08fbe28.

Arm Evaluation commit Engine pin Knowledge pin
baseline 23651b967da88b13849273412e56c70ee32c538d edd46ef34e9b38d7cc2fc3e1c1c806ff8e476ab6 f820aa1e8515a6483b828d9a5b1c55112461b4d9
candidate dabfc4f1d5980abb08a4b73ea0ba52bb962d9a63 29c3407af10321af34574fe292deda3e83bca7cf bf9513972139eac68665fde51cd478bc2f496b84

Baseline

Run: https://github.com/microsoft/BC-Bench/actions/runs/39432795249; conclusion: success; wall clock: 7.9 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.

Entry Expected Generated Missed Unexpected F1 AI credits Agent seconds
synthetic__sec-internal-reschedule-job-01 0 2 0 2 0 unavailable 321.0167293

Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.

Aggregate metric Value
total 1
expected_comment_count 0
generated_comment_count 2
matched_comment_count 0
missed_comment_count 0
incorrect_comment_count 2
precision 0
recall 1
f1 0

Candidate

Run: https://github.com/microsoft/BC-Bench/actions/runs/39434019370; conclusion: success; wall clock: 6.3 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.

Entry Expected Generated Missed Unexpected F1 AI credits Agent seconds
synthetic__sec-internal-reschedule-job-01 0 1 0 1 0 unavailable 241.1920114

Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.

Aggregate metric Value
total 1
expected_comment_count 0
generated_comment_count 1
matched_comment_count 0
missed_comment_count 0
incorrect_comment_count 1
precision 0
recall 1
f1 0

Missing telemetry is unavailable, not zero. Evaluation-only metrics exclude candidate generation and are not the full-cycle cost.
Human review must verify source-patch fidelity, gold correctness, and target attribution. No automatic merge or branch-protection claim is made.

Cycle usage and elapsed time (running, as of 2026-10-20T13:57:39.5040961+00:00)

Orchestrator work: 1431.455 seconds. This is not the completed GitHub workflow duration.

Stage / attempt Status / outcome Elapsed seconds
preflight / 1 completed / 7.522
quality_preparation / 1 completed / 120.914
gold_preparation / 1 completed / selected_new 383.955
evaluation_preparation / 1 completed / 30.633
baseline / 1 completed / success 505.636
candidate / 1 completed / success 382.012
gate_verdict / 1 completed / regression 0.01
publication / 1 running / 0.024
receipts / 1 not_started / unavailable
quality_validation / 1 completed / 4.437
gold_attempt / 1 failed / invalid_selection 215.539
gold_attempt / 2 completed / validated 152.722
Measure Known subtotal Whole-cycle total Known / required components
ai_credit: aiCredits 110.35342 unavailable 3 / 7
premium_request: premiumRequests 57 unavailable 3 / 7
token: inputTokens 11656037 unavailable 5 / 7
token: outputTokens 135851 unavailable 5 / 7
token: totalTokens 11791888 unavailable 5 / 7

Subtotals are CLI/Bench-reported usage, not invoices. Missing values are not zero. Emitted-span coverage does not prove complete child/background billing; judge usage is not exported. Premium requests are not AI credits or currency.
Nested stage, agent and API durations are not added into cycle wall clock. Root queue/setup, telemetry export, artifact upload and later dashboard publication are excluded.
PR evidence is an as-of snapshot before publication completes. Final-for-orchestrator metrics are emitted to self-improvement-cycle.json in the root self-improvement-feedback artifact and its Actions summary when persistence succeeds; a running checkpoint is not final evidence.
Root run: https://github.com/microsoft/BC-ALAgentsInternal/actions/runs/39431396113/attempts/1

@github-code-quality

Copy link
Copy Markdown
Contributor

Code coverage overview

Languages: Python

Python / code-coverage/pytest

main 7c98b75 self-improvement/bca... ea00574 +/-
88% 88% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant