Skip to content

dataset(code-review): add reaction gold answers from BCApps PR 12152-neg-pr12152-20261020 - #981

Draft
Wenjie Fan (gggdttt) wants to merge 1 commit into
mainfrom
self-improvement/bcapps-12152-neg-pr12152-20261020-synthetic-eval
Draft

Wenjie Fan (gggdttt) wants to merge 1 commit into
mainfrom
self-improvement/bcapps-12152-neg-pr12152-20261020-synthetic-eval

Conversation

@gggdttt

@gggdttt Wenjie Fan (gggdttt) commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds code-review gold answers from explicit BCApps PR feedback.

Negative guards use exact source-file patches at immutable reviewed revisions, not invented synthetic code. Their targets are omitted from both expected and ignored comments; new negative-only entries have no expected findings.
Existing eligible gold answers are reused without changing their payloads.

Accepted findings

Rejected findings

Knowledge dependency

Validation

See the gate-owned offline evaluation section below.

Generated by the BC-ALAgentsInternal self-improvement workflow.

Offline evaluation: regression

Candidate correctness failed: unexpected or missed findings remain. Existing ignored gold comments retain their neutral scoring semantics.

Preparation attempt 1: validated.

Selection: new. New: synthetic__testing-transactionmodel-not-required-01. Reused (complete payloads): ``.

  • synthetic__testing-transactionmodel-not-required-01 / false_positive_guard / [MCP] Clear environment description after environment copy BCApps#12152 (comment): Thumbs-down feedback plus the maintainer reply rejecting TransactionModel usage altogether (property should be removed from the product) show the AutoCommit->AutoRollback suggestion was wrong in substance, not just severity; the accepted fix deleted the attribute instead. No expected or ignored comment exists for this target in the dataset, so a guard expecting no finding on the TransactionModel line is faithful without inventing a clean precondition.
    Coverage references and outcome shapes are validated mechanically. Semantic equivalence, severity calibration and recommendation quality are NOT proved by these checks or a matching F1.

Common engine code: ecf8e31759d6ddd6d78e3a0b7836b40134368009; dataset SHA256: 8A36A70E92D9C5D6ADB179F4BB39A29409B116ACE8CB29764A4DF2E3E2DF9383.
Model: gpt-5.6-luna; judge: gpt-5.3-codex. Exact D: synthetic__testing-transactionmodel-not-required-01.
Dataset base: 7c98b750c200d88ed0a81daaea5e71184a3af01b; candidate: 3b3dfd9de5459cb4fc2f71285a4b6681249f8169.

Arm Evaluation commit Engine pin Knowledge pin
baseline f4ee822aa76bed8d018029d2a6d3deb7db59a530 79439b9347c5e3d8d6b3b681dad25d23fb64ac03 ce45c5abd9a35d5dbd48f51f6b5a10a418c7f70d
candidate fb05910bc418a431dc0579cfea243728d3d76eaf 6aebeecf0606079cdc2ea30b2031a78ee09b2644 920291ddfa352f43ec90e7539c0bf3c645afadbb

Baseline

Run: https://github.com/microsoft/BC-Bench/actions/runs/39436917453; conclusion: success; wall clock: 7.4 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.

Entry Expected Generated Missed Unexpected F1 AI credits Agent seconds
synthetic__testing-transactionmodel-not-required-01 0 0 0 0 1 unavailable 282.3635775

Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.

Aggregate metric Value
total 1
expected_comment_count 0
generated_comment_count 0
matched_comment_count 0
missed_comment_count 0
incorrect_comment_count 0
precision 1
recall 1
f1 1

Candidate

Run: https://github.com/microsoft/BC-Bench/actions/runs/39438081729; conclusion: success; wall clock: 6.8 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.

Entry Expected Generated Missed Unexpected F1 AI credits Agent seconds
synthetic__testing-transactionmodel-not-required-01 0 1 0 1 0 unavailable 258.8476013

Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.

Aggregate metric Value
total 1
expected_comment_count 0
generated_comment_count 1
matched_comment_count 0
missed_comment_count 0
incorrect_comment_count 1
precision 0
recall 1
f1 0

Missing telemetry is unavailable, not zero. Evaluation-only metrics exclude candidate generation and are not the full-cycle cost.
Human review must verify source-patch fidelity, gold correctness, and target attribution. No automatic merge or branch-protection claim is made.

Cycle usage and elapsed time (running, as of 2026-10-20T14:26:14.3049835+00:00)

Orchestrator work: 1186.404 seconds. This is not the completed GitHub workflow duration.

Stage / attempt Status / outcome Elapsed seconds
preflight / 1 completed / 6.217
quality_preparation / 1 completed / 100.382
gold_preparation / 1 completed / selected_new 136.48
evaluation_preparation / 1 completed / 24.552
baseline / 1 completed / success 474.649
candidate / 1 completed / success 443.288
gate_verdict / 1 completed / regression 0.02
publication / 1 running / 0.037
receipts / 1 not_started / unavailable
quality_validation / 1 completed / 8.398
gold_attempt / 1 completed / validated 119.885
Measure Known subtotal Whole-cycle total Known / required components
ai_credit: aiCredits 61.56699 unavailable 2 / 6
premium_request: premiumRequests 42 unavailable 2 / 6
token: inputTokens 11032817 unavailable 4 / 6
token: outputTokens 103087 unavailable 4 / 6
token: totalTokens 11135904 unavailable 4 / 6

Subtotals are CLI/Bench-reported usage, not invoices. Missing values are not zero. Emitted-span coverage does not prove complete child/background billing; judge usage is not exported. Premium requests are not AI credits or currency.
Nested stage, agent and API durations are not added into cycle wall clock. Root queue/setup, telemetry export, artifact upload and later dashboard publication are excluded.
PR evidence is an as-of snapshot before publication completes. Final-for-orchestrator metrics are emitted to self-improvement-cycle.json in the root self-improvement-feedback artifact and its Actions summary when persistence succeeds; a running checkpoint is not final evidence.
Root run: https://github.com/microsoft/BC-ALAgentsInternal/actions/runs/39436159441/attempts/1

@github-code-quality

Copy link
Copy Markdown
Contributor

Code coverage overview

Languages: Python

Python / code-coverage/pytest

main 7c98b75 self-improvement/bca... 3b3dfd9 +/-
88% 88% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant