Reduce exception overhead - #2520
Open
Manodasan Wignarajah (manodasanW) wants to merge 2 commits into
Open
Conversation
Cache boxed language-error flags, avoid duplicate Exception.Data scans, and build restricted error messages without intermediate strings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ddbd67fd-01c2-4b1b-b23f-f9eb0ad8f70e
Skip dictionary key lookups when exception metadata is empty and avoid reading the language-error flag unless a restricted error object was found. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the benchmarks, the native exception saves 24 bytes from cached Boolean metadata and approximately 88 bytes by avoiding intermediate message strings. The restored managed exception saves the 24-byte Boolean box.