[SM6.10] LinAlg Validation: MatrixAccumulateToMemory - #8835
Open
Ashley Coleman (V-FEXrt) wants to merge 1 commit into
Open
[SM6.10] LinAlg Validation: MatrixAccumulateToMemory#8835Ashley Coleman (V-FEXrt) wants to merge 1 commit into
Ashley Coleman (V-FEXrt) wants to merge 1 commit into
Conversation
| CI, ValidationRule::InstrLinAlgMatrixUseMismatch, | ||
| {"Input", MatrixUseToString(Mat->Use), "Accumulator"}); | ||
|
|
||
| GEPOperator *GSGEP = cast<GEPOperator>(Op.get_memory()); |
There was a problem hiding this comment.
Some of the code from here downwards looks extremely similar to some of the code in #8834. Is there a shared helper that could be factored out?
Collaborator
Author
There was a problem hiding this comment.
Yeah the code is almost identical but there are some extra chunks in various places that make a giant reused function not work. Once the stack merges I'll circle around and look into extracting some of them. Some the of pending changes also make the duplicated code a bit simpler as well
Fixes #8507 Implements LinAlg MatrixAccumulateToMemory validation rules
Ashley Coleman (V-FEXrt)
force-pushed
the
linalg-vali-matrixaccumulatetomemory
branch
from
September 1, 2026 21:35
01ad128 to
c6cf2ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8507
Implements LinAlg MatrixAccumulateToMemory validation rules
Stack created with GitHub Stacks CLI • Give Feedback 💬