[dxv] Disallow work graps in DXIL 1.10 - #8862
Open
Chris B (llvm-beanz) wants to merge 4 commits into
Open
Conversation
In DXIL 1.10, we're disallowing all the dxil operations associated with work graphs. This is captured in the Dxil 1.10 specification in [PR microsoft#918] (microsoft/hlsl-specs#918). Assisted-by: Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
Disallows work graph DXIL operations in Shader Model/DXIL 1.10 validation.
Changes:
- Adds maximum shader-model metadata for DXIL operations.
- Caps work graph operations at Shader Model 6.9.
- Adds validation coverage and a release note.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
utils/hct/hctdb.py |
Defines operation shader-model upper bounds. |
utils/hct/hctdb_instrhelp.py |
Generates maximum-version validation checks. |
tools/clang/test/LitDXILValidation/work-graph-opcodes-sm-6-10.ll |
Tests rejection of work graph operations. |
docs/ReleaseNotes.md |
Documents removal of support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Damyan Pepper (damyanp)
approved these changes
Aug 31, 2026
Helena Kotas (hekota)
approved these changes
Aug 31, 2026
| - Added `BFloat16` to the ComponentType enum in DxilConstants and the linalg | ||
| header [#8722](https://github.com/microsoft/DirectXShaderCompiler/issues/8722) | ||
| header [#8722](https://github.com/microsoft/DirectXShaderCompiler/issues/8722). | ||
| - Removed work graph support from Shader Model 6.10, and DXIL 1.10 [microsoft/hlsl-specs#915](https://github.com/microsoft/hlsl-specs/issues/915) |
Comment on lines
+1041
to
+1044
| for i in ( | ||
| "AllocateNodeOutputRecords,GetNodeRecordPtr,IncrementOutputCount,OutputComplete,GetInputRecordCount,FinishedCrossGroupSharing,BarrierByNodeRecordHandle,CreateNodeOutputHandle,IndexNodeHandle,AnnotateNodeHandle,CreateNodeInputRecordHandle,AnnotateNodeRecordHandle,NodeOutputIsValid,GetRemainingRecursionLevels" | ||
| ).split(","): | ||
| self.name_idx[i].shader_model_max = 6, 9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DXIL 1.10, we're disallowing all the dxil operations associated with work graphs.
This is captured in the DXIL 1.10 specification in microsoft/hlsl-specs#918.
Assisted-by: Copilot