[HLSLExec] Make execution tests directly consumable by the HLK by joaosaffran · Pull Request #9104 · microsoft/DirectXShaderCompiler

joaosaffran · 2026-11-06T21:29:54Z

Embed the HLK metadata that the DXCBuild conversion scripts used to inject, so ExecutionTest.cpp and ShaderOpArithTable.xml can be built into the HLK as-is. Under _HLK_CONF the test class is exposed as DxilConfTest to keep existing HLK waivers matching.

Copilot

🟡 Changes recommended

The process-global verifier setup does not configure the runtime used by the selected Agility SDK factory, so /p:DriverVerifier=true can leave actual test devices unverified.

1 open issue

Configure driver verification through the selected SDK factory · New

What changed in this PR

Makes HLSL execution tests directly consumable by the Windows Hardware Lab Kit (HLK), replacing metadata injection by DXCBuild conversion scripts while preserving waiver matching.

Changes:

Embeds HLK identifiers, descriptions, names, and specifications in test methods and XML rows.
Exposes the test class as DxilConfTest under _HLK_CONF.
Simplifies test dependencies and adds runtime-configurable driver verification.

File	Description
tools/clang/unittests/HLSLExec/TableParameterHandler.h	Uses shared test utility headers for all builds.
tools/clang/unittests/HLSLExec/ShaderOpArithTable.xml	Adds HLK metadata to data-driven test rows.
tools/clang/unittests/HLSLExec/ExecutionTest.cpp	Adds HLK method metadata, compatible class naming, and verifier configuration.

_{Review effort: Balanced}

Copilot

🔵 Needs a closer look

The driver-verifier toggle targets the process-global runtime rather than the selected device-factory runtime, so verification can be reported as enabled without applying to the test devices.

1 open issue

Configure driver verification through the selected SDK factory

1 previously missed issue

In code that hasn't changed since last review

Fix the “intrinrics” typo in the HLK description

tools/clang/unittests/HLSLExec/ExecutionTest.cpp:267

The new HLK description misspells “intrinsics” as “intrinrics”. Please correct it so the test description is spelled correctly in HLK.

_{Review effort: Balanced}

Copilot

🟡 Changes recommended

The unguarded function leaves an unused Enabled parameter when _HLK_CONF is undefined, causing normal MSVC execution-test builds to fail because C4100 is treated as an error.

2 open issues

_{Review effort: Balanced}

Copilot

🔵 Needs a closer look

When _HLK_CONF is undefined, the helper leaves Enabled unused, triggering C4100 as an error and breaking the normal Windows ExecHLSLTests build.

2 open issues

_{Review effort: Balanced}

Copilot

🔵 Needs a closer look

A minor finding omitted from the published review requires human judgment to determine whether it affects approval.

No open issues 🎉

2 resolved since last review

_{Review effort: Balanced}

Alex Sepkowski (alsepkow)

Adding a couple comments

Copilot

🟡 Changes recommended

HLK-visible metadata contains a typo and incorrectly identifies the msad4 test as Bfi instead of Msad.

2 open issues

_{Review effort: Balanced}

Alex Sepkowski (alsepkow) · 2026-11-14T00:27:30Z

+             Kits.Description="Verifies the Bfi DXIL instruction."
+             Kits.TestId="ca7a8fe3-b671-4b2a-90d3-0efca2abff87"
+             Kits.Specification="Device.Graphics.WDDM22.AdapterRender.D3D12.DXILCore.ShaderModel60.CoreRequirement"
+             Kits.TestName="D3D12 - DXIL Core Test - Bfi instruction">


Whoops, this sounds like an existing bug. I'd suggest we file a bug to look at this after we get this checked in.

Embed the HLK metadata that the DXCBuild conversion scripts used to inject, so ExecutionTest.cpp and ShaderOpArithTable.xml can be built into the HLK as-is. The test class is renamed from ExecutionTest to DxilConfTest so existing HLK waivers keep matching, and the TAEF name filters in hcttest.cmd are updated to match. To match the former gen_DxilConf.cpp template under _HLK_CONF: - Drop the TAEF Parallel/Priority class properties, which the HLK class did not have. - Exclude the non-HLK-only ReportLiveObjects/WriteInfoQueueMessages helpers, which do not compile with UNICODE. The template's DriverVerifier toggle and skipped IsNormalTest stub are intentionally not carried over: the former is no longer used, and the latter's HLK references were removed when microsoft#7768 was resolved. DxilConfTestUtils.h is no longer needed: dxc/Support/Global.h provides its macros, and ExecutionTest.cpp already defines contains(). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

joaosaffran · 2026-11-13T18:17:23Z

 public:
-  BEGIN_TEST_CLASS(ExecutionTest)
+  BEGIN_TEST_CLASS(DxilConfTest)
  TEST_CLASS_PROPERTY(L"Parallel", L"true")


This lets TAEF know that it could run the tests in parallel. The CLI stil requires the \parallel to actually run in parallel.

Alex Sepkowski (alsepkow) · 2026-11-13T22:16:27Z

 set TEST_USE_LIT=1
 set TEST_CLANG_FILTER=
-set TEST_EXEC_FILTER=ExecutionTest::*
+set TEST_EXEC_FILTER=DxilConfTest::*


nit: Seems a little weird for this to be called 'TEST_EXEC_FILTER' now if we change the class name.

Although....the dll is still named 'ExecHLSLTests.dll'. It might be worth doing a follow up change on that instead.

Thoughts?

Copilot AI balanced review requested due to automatic review settings November 6, 2026 21:29

github-project-automation Bot added this to HLSL Roadmap Nov 6, 2026

github-project-automation Bot moved this to New in HLSL Roadmap Nov 6, 2026

Copilot started reviewing on behalf of joaosaffran November 6, 2026 21:30

View session

Copilot AI reviewed Nov 6, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/ExecutionTest.cpp Resolved

Copilot AI balanced review requested due to automatic review settings November 7, 2026 00:14

Copilot started reviewing on behalf of joaosaffran November 7, 2026 00:15

View session

joaosaffran force-pushed the users/joaosaffran/remove-hlk-conversion-script branch from 550dd21 to fb1851a Compare November 7, 2026 00:16

Copilot AI reviewed Nov 7, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings November 7, 2026 00:18

Copilot started reviewing on behalf of joaosaffran November 7, 2026 00:19

View session

Copilot AI reviewed Nov 7, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/ExecutionTest.cpp Resolved

Copilot AI balanced review requested due to automatic review settings November 7, 2026 00:33

Copilot started reviewing on behalf of joaosaffran November 7, 2026 00:33

View session

Copilot AI reviewed Nov 7, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings November 7, 2026 00:42

Copilot started reviewing on behalf of joaosaffran November 7, 2026 00:42

View session

Copilot AI reviewed Nov 7, 2026

View reviewed changes

Alex Sepkowski (alsepkow) reviewed Nov 9, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/ExecutionTest.cpp Resolved

Comment thread tools/clang/unittests/HLSLExec/ExecutionTest.cpp Resolved

Alex Sepkowski (alsepkow) reviewed Nov 9, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/ExecutionTest.cpp Resolved

Alex Sepkowski (alsepkow) reviewed Nov 10, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/ExecutionTest.cpp Resolved

joaosaffran force-pushed the users/joaosaffran/remove-hlk-conversion-script branch from e0dfdff to fd95310 Compare November 10, 2026 01:03

Copilot AI balanced review requested due to automatic review settings November 10, 2026 01:03

Copilot started reviewing on behalf of joaosaffran November 10, 2026 01:10

View session

Copilot AI reviewed Nov 10, 2026

View reviewed changes

joaosaffran marked this pull request as draft November 11, 2026 18:16

joaosaffran force-pushed the users/joaosaffran/remove-hlk-conversion-script branch from fd95310 to 053b291 Compare November 12, 2026 21:39

joaosaffran force-pushed the users/joaosaffran/remove-hlk-conversion-script branch from 053b291 to d80a898 Compare November 12, 2026 23:34

joaosaffran commented Nov 13, 2026

View reviewed changes

joaosaffran requested a review from Alex Sepkowski (alsepkow) November 13, 2026 18:48

João Saffran (joaosaffran-zz) added 3 commits November 13, 2026 10:49

fix typos

71df259

format

a1f086f

fix ci error?

4fa246b

Alex Sepkowski (alsepkow) reviewed Nov 13, 2026

View reviewed changes

Alex Sepkowski (alsepkow) approved these changes Nov 14, 2026

View reviewed changes

Conversation

joaosaffran commented Nov 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Alex Sepkowski (alsepkow) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Alex Sepkowski (alsepkow) Nov 14, 2026

Choose a reason for hiding this comment

Uh oh!

joaosaffran Nov 13, 2026

Choose a reason for hiding this comment

Uh oh!

Alex Sepkowski (alsepkow) Nov 13, 2026

Choose a reason for hiding this comment

Uh oh!

Alex Sepkowski (alsepkow) Nov 14, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants