Repository navigation
Change lavapipe tests to always default to false - #9124
Open
joaosaffran wants to merge 1 commit into
Open
joaosaffran wants to merge 1 commit into
joaosaffran wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change making lavapipe/offload tests opt-in.
No open issues 🎉
What changed in this PR
Makes lavapipe/offload tests opt-in, preventing non-PR builds such as the release-branch sync in #9122 from running them automatically.
Changes:
- Defaults the test-running flag to
falsefor all builds. - Enables tests only for pull-request builds with the
run-offload-testslabel.
| File | Description |
|---|---|
azure-pipelines.yml |
Moves the default-off setting outside the PR check while retaining label-based opt-in. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch #9122 is not considered a pull request, so GitHub doesn't check the label to see if it should run offload tests. This change defaults to running the tests to false and only runs on PRs with the correct label