Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (2060 lines, 13 files), I've queued these reviewers:
How this works
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes AB#76716, where a remote client can fail with
Channel context not foundafter a detached container is attached.Data stores are captured sequentially when producing the attach summary. Summarizing a later data store can bind a DDS owned by an earlier, already-captured data store through normal handle serialization. The DDS then becomes visible and sends ops after attach, but remote clients never received it in the earlier data store's snapshot.
This change:
DataProcessingErrorcontaining actionable diagnostics.The end-to-end regression uses ordinary
SharedMaphandles across two data stores. It fails on the previous implementation withChannel context not foundand passes with this change.Reviewer Guidance
The review process is outlined in the pull request guidelines.
The key logic is the fixed-point attach capture in
ChannelCollection. Please review the versioned path, the fingerprint fallback for legacy runtimes, and the producer-side stabilization guard.