ci: refactor client build to have test stage follow build - #28246
Open
Jason Hartman (jason-ha) wants to merge 1 commit into
Open
Jason Hartman (jason-ha) wants to merge 1 commit into
Jason Hartman (jason-ha) wants to merge 1 commit into
Conversation
Simply separate test jobs under new verification stage. Future: consider a limited build job building only the parts needed to build packages. For example linting is not required during build and can be moved to verification stage.
Jason Hartman (jason-ha)
requested review from
Abram Sanderson (Abe27342),
Craig Macomber (Microsoft) (CraigMacomber),
Joshua Smithrud (Josmithr),
MarioJGMsoft and
Alex Villarreal (alexvy86)
and
a lite review from Copilot
September 17, 2026 22:00
github-actions
Bot
added
area: tools
area: build
Copilot started reviewing on behalf of
Jason Hartman (jason-ha)
September 17, 2026 22:00
View session
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (19 lines, 1 files), I've queued these reviewers:
How this works
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Telemetry may not run when the build fails due to the new stage dependency.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Refactors the client pipeline to separate build and verification stages.
Changes:
- Adds a dedicated verification stage for tests.
- Updates stage dependencies and output references.
- Redirects telemetry dependencies.
File summaries
| File | Summary |
|---|---|
tools/pipelines/templates/build-npm-client-package.yml |
Separates build and verification stages; telemetry must preserve execution on build failures. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| dependsOn: | ||
| - build | ||
| # This also depends on build stage transitively. | ||
| - verification |
Contributor
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply separate test jobs under new verification stage.
Future: consider a limited build job building only the parts needed to build packages. For example linting is not required during build and can be moved to verification stage.