Skip to content

fix(website): use semantic headings for homepage cards - #28255

Draft
shlevari wants to merge 2 commits into
microsoft:mainfrom
shlevari:wi83301-site-heading-semantics
Draft

shlevari wants to merge 2 commits into
microsoft:mainfrom
shlevari:wi83301-site-heading-semantics

Conversation

@shlevari

@shlevari shlevari commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Description

Use semantic level-three headings for homepage card titles in the key features, services, and partners sections. This improves heading navigation for assistive technology while preserving the existing visual spacing.

Adds a Playwright accessibility test that verifies each affected card title is exposed as a visible level-three heading.

AB#83301

Reviewer Guidance

The review process is outlined in the pull request guidelines.

Please verify that the heading hierarchy is appropriate for each homepage section and that the CSS changes preserve the existing layout.

shlevari and others added 2 commits September 18, 2026 10:30
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation area: tools area: repo Repo related work area: website base: main PRs targeted against main branch labels Sep 18, 2026
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (32 lines, 7 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@shlevari
shlevari marked this pull request as ready for review September 18, 2026 22:50
Copilot AI lite review requested due to automatic review settings September 18, 2026 22:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Updates homepage card titles to semantic <h3> headings, preserving existing spacing and adding accessibility coverage.

Changes:

  • Converts key feature, service, and partner titles to <h3> headings.
  • Adds CSS margin resets.
  • Adds a Playwright accessibility test.
File Description
website/​test/​site-tests/​Accessibility.spec.ts Verifies affected titles are visible level-three headings.
website/​src/​css/​home/​serviceSection.css Preserves service title spacing.
website/​src/​css/​home/​partnersSection.css Preserves partner title spacing.
website/​src/​css/​home/​keyFeatureCard.css Preserves key feature title spacing.
website/​src/​components/​home/​serviceSection.tsx Uses <h3> for service titles.
website/​src/​components/​home/​partnersSection.tsx Uses <h3> for partner titles.
website/​src/​components/​home/​keyFeatureCard.tsx Uses <h3> for key feature titles.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

$ start-server-and-test "npm run serve -- --host 127.0.0.1 --no-open" http://127.0.0.1:3000 check-links
1: starting server using command "npm run serve -- --host 127.0.0.1 --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-website@0.0.0 serve
> docusaurus serve --host 127.0.0.1 --no-open

[SUCCESS] Serving "build" directory at: http://127.0.0.1:3000/

> fluid-framework-website@0.0.0 check-links
> linkcheck http://127.0.0.1:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  658102 links
    3579 destination URLs
    3898 URLs ignored
       0 warnings
       0 errors


@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Fleet Review — Clean

No issues found across the reviewer fleet for this run.

View run

@shlevari
shlevari marked this pull request as draft September 18, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: repo Repo related work area: tools area: website base: main PRs targeted against main branch documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants