FIX: reject non-finite AddImageText rotation - #2622
Open
fei (feiiiiii5) wants to merge 2 commits into
Open
Conversation
Roman Lutz (romanlutz)
approved these changes
Sep 10, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symmetric follow-up to #2560 (AudioSpeed) and #2566 (AudioEcho), same file as #2563 (AddImageText font size).
Audit: checked audio converters (speed/echo already finite-guarded; volume/white-noise plus image saturation/rotation are covered by open #2613, untouched here) and image converters (overlay opacity already rejects nan/inf via chained comparison; resizing already guards finite). AddImageText rotation was the remaining float converter param with no construction-time validation: NaN/Inf/-Inf were accepted at construction and only failed late inside PIL (overlay.rotate raises ValueError: cannot convert float NaN to integer).
Fix: math.isfinite guard in AddImageTextConverter.init, mirroring #2560/#2566.
Tests: parametrized nan/inf/-inf constructor rejection in test_add_image_text_converter.py. Local: 26 passed in test_add_image_text_converter.py; 45 passed across font-size/rotation/audio regression files; ruff 0.16.6 check and format clean.