FIX: Temporarily allow reviewed Alembic rewrite - #2623
Closed
Richard Lundeen (richlundeen) wants to merge 1 commit into
Closed
FIX: Temporarily allow reviewed Alembic rewrite#2623Richard Lundeen (richlundeen) wants to merge 1 commit into
Richard Lundeen (richlundeen) wants to merge 1 commit into
Conversation
Pin the temporary Alembic immutability exception to the exact blob reviewed in microsoft#2583. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyrit/memory/alembic/versions/1b3d5f7a9c2e_persist_scored_expectation.py.3cb40abf25ffafe4cbd1ddfda213e02e54458d91, which is the reviewed file content from PERF: Optimize attack and scenario history #2583 atb949e06a2947fa163a5ed35fa8608b48ec262132.HEAD~1..HEADchecks. All other migration modifications and all other content for this migration still fail.Validation
UV_NO_SYNC=1 uv run --frozen pytest tests/unit/build_scripts/test_enforce_alembic_revision_immutability.py -q(26 passed)UV_NO_SYNC=1 uv run --frozen pre-commit run --all-files(all substantive hooks passed;check-added-large-filescrashed insidegit check-attrwhen it received the full Windows file list)UV_NO_SYNC=1 uv run --frozen pre-commit run check-added-large-files --files build_scripts/enforce_alembic_revision_immutability.py tests/unit/build_scripts/test_enforce_alembic_revision_immutability.py --verbose(passed)Required merge sequence
This is a temporary prerequisite for #2583. Merge this PR first. Then update #2583 from
mainand merge it. Remove this exception immediately after #2583 merges.