Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion typescript/src/model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ function getRetryDelayMs(response: Response, defaultMs: number, maxMs: number):
const retryAfter = response.headers.get("retry-after");
if (retryAfter) {
const seconds = parseInt(retryAfter, 10);
if (!isNaN(seconds)) {
if (Number.isFinite(seconds) && seconds >= 0) {
return Math.min(seconds * 1000, maxMs);
}
}
Expand Down
24 changes: 24 additions & 0 deletions typescript/tests/model.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,30 @@ describe("createOpenAILanguageModel (Chat Completions API)", () => {
assert.equal(result.data, "OK after 503 retry");
assert.equal(capturedRequests.length, 2, "Expected 2 requests: initial + 1 retry");
});

test("uses the configured pause for a negative retry-after header", async () => {
setupFetch([
makeErrorResponse(429, "Too Many Requests", -1000),
makeChatCompletionsResponse("OK after retry"),
]);
const model = createOpenAILanguageModel("sk-test", "gpt-4");
model.retryMaxAttempts = 3;
model.retryPauseMs = 1000;
const scheduledDelays = [];
const originalSetTimeout = globalThis.setTimeout;
globalThis.setTimeout = (callback, delay, ...args) => {
scheduledDelays.push(delay);
queueMicrotask(() => callback(...args));
};
try {
const result = await model.complete("test");
assert.equal(result.success, true);
assert.equal(result.data, "OK after retry");
assert.deepEqual(scheduledDelays, [1000]);
} finally {
globalThis.setTimeout = originalSetTimeout;
}
});
});

// ---------------------------------------------------------------------------
Expand Down