Skip to content

Run the full TypeScript test suite in Node CI - #505

Merged
robgruen merged 1 commit into
mainfrom
fix/ci-run-npm-test
Nov 1, 2026
Merged

robgruen merged 1 commit into
mainfrom
fix/ci-run-npm-test

Conversation

@robgruen

@robgruen robgruen commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Node.js CI currently installs dependencies and builds the workspaces but never executes the TypeScript test suite. Add an unconditional npm test step after npm run build-all in every existing Node matrix job.

  • Preserve the existing runtime matrix, build steps, and permissions.
  • Add a YAML regression test that requires the full test command and prevents conditional or ignored test failures.
  • Document the CI test coverage in the TypeScript README.

This is a separate CI hotfix prompted by reviewing #501; it does not modify that contributor's PR.

Verification

  • Full npm test on this branch: 197/197 passed on each of Node 22.23.4, 24.22.1, and 26.12.1, with no failures or skipped tests.
  • Full npm test on the exact fix(model): return actionable errors when undici is missing #501 commit daa9bd6b477786e06cc8c3fd952da5ca56cafe44: 198/198 passed on each of the same three runtimes, with no failures or skipped tests.
  • New Node CI workflow regression test passed using the repository's existing YAML/test tools.
  • git diff --check passed.

Local validation restored only test-required packages because the environment's package feed returns a 404 for an unrelated workspace dependency. The examples used their exact locked TypeScript 5.9.3 compiler; no source, manifests, or lockfiles were changed to make the tests pass.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 1, 2026 23:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change adding TypeScript test execution to the existing Node.js CI matrix.

No open issues 🎉

What changed in this PR

Closes the TypeScript test-execution gap in Node.js CI without changing the existing runtime matrix, build steps, or permissions. This is a standalone CI hotfix prompted by #501, not a modification of that contribution.

Changes:

  • Run npm test after the workspace build in every existing Node matrix job.
  • Add a workflow regression test enforcing the full test command and rejecting conditional execution or ignored failures.
  • Document the CI test coverage in the TypeScript README.
File Description
typescript/​README.md Documents test execution across the Node.js CI matrix.
tools/​tests/​node-ci.test.mjs Checks command order, working directory, and test failure enforcement.
.github/​workflows/​ci.js.yml Adds npm test after npm run build-all.

Review effort: Balanced

@robgruen
robgruen merged commit 4b1d777 into main Nov 1, 2026
14 checks passed
robgruen added a commit to yushiwuzhengjianyuzi/TypeChat that referenced this pull request Nov 1, 2026
Refresh microsoft#469 against current main after the CI test step landed in microsoft#505. Preserve the contributor's validator lifecycle fix and all current regression tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants