Repository navigation
Run the full TypeScript test suite in Node CI - #505
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change adding TypeScript test execution to the existing Node.js CI matrix.
No open issues 🎉
What changed in this PR
Closes the TypeScript test-execution gap in Node.js CI without changing the existing runtime matrix, build steps, or permissions. This is a standalone CI hotfix prompted by #501, not a modification of that contribution.
Changes:
- Run
npm testafter the workspace build in every existing Node matrix job. - Add a workflow regression test enforcing the full test command and rejecting conditional execution or ignored failures.
- Document the CI test coverage in the TypeScript README.
| File | Description |
|---|---|
typescript/README.md |
Documents test execution across the Node.js CI matrix. |
tools/tests/node-ci.test.mjs |
Checks command order, working directory, and test failure enforcement. |
.github/workflows/ci.js.yml |
Adds npm test after npm run build-all. |
Review effort: Balanced
robgruen
added a commit
to yushiwuzhengjianyuzi/TypeChat
that referenced
this pull request
Nov 1, 2026
Refresh microsoft#469 against current main after the CI test step landed in microsoft#505. Preserve the contributor's validator lifecycle fix and all current regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node.js CI currently installs dependencies and builds the workspaces but never executes the TypeScript test suite. Add an unconditional
npm teststep afternpm run build-allin every existing Node matrix job.This is a separate CI hotfix prompted by reviewing #501; it does not modify that contributor's PR.
Verification
npm teston this branch: 197/197 passed on each of Node 22.23.4, 24.22.1, and 26.12.1, with no failures or skipped tests.npm teston the exact fix(model): return actionable errors when undici is missing #501 commitdaa9bd6b477786e06cc8c3fd952da5ca56cafe44: 198/198 passed on each of the same three runtimes, with no failures or skipped tests.git diff --checkpassed.Local validation restored only test-required packages because the environment's package feed returns a 404 for an unrelated workspace dependency. The examples used their exact locked TypeScript 5.9.3 compiler; no source, manifests, or lockfiles were changed to make the tests pass.