Repository navigation
Allow related PR citations without blocking accepted work - #509
Merged
Merged
Conversation
Treat citations as preserved evidence, not reservations on independent work. Keep target-Issue links and mentions, revision freshness, owned-branch checks, and publication-intent safeguards. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change to how related PR citations affect accepted implementation work.
No open issues 🎉
What changed in this PR
This PR lets independently accepted implementation work proceed when its agreement cites a related open PR, while preserving checks for work competing on the target Issue.
Changes:
- Remove citation membership alone as a blocker; retain checks for open PRs linked to or naming the target Issue.
- Add regression coverage for related citations, preserved credit, competing work, and referenced-revision freshness.
- Document the distinction without changing authorization or spending controls.
| File | Description |
|---|---|
tools/tests/issue-implementation.test.mjs |
Add fixtures and regression tests for related citations and retained safeguards. |
tools/issue-implementation.mjs |
Stop treating acceptance references alone as competing contributions. |
AUTOMATION.md |
Clarify which open PRs block accepted implementation work. |
Review effort: Balanced
Verify preservation of the entire agreement instead of using a literal URL substring assertion that CodeQL misclassifies as URL sanitization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honor the owner's decision that independently accepted work should not wait merely because its agreement cites another open PR. The immediate example is the accepted documentation work in #220 versus the related runtime-conversion work in #466.
Validation
Operational state
The exact build command for the existing #220 acceptance was generated, but not posted or executed. The coding activation flag remains unset. This PR does not merge or close #466, accept additional work, activate spending, or start the coding pilot. Normal integration and freshness checks still require reevaluation if relevant source changes land first.