Skip to content

Allow related PR citations without blocking accepted work - #509

Merged
robgruen merged 2 commits into
mainfrom
dev/robgruen/related-pr-evidence
Nov 2, 2026
Merged

robgruen merged 2 commits into
mainfrom
dev/robgruen/related-pr-evidence

Conversation

@robgruen

@robgruen robgruen commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Honor the owner's decision that independently accepted work should not wait merely because its agreement cites another open PR. The immediate example is the accepted documentation work in #220 versus the related runtime-conversion work in #466.

  • Remove the blanket block based solely on membership in the acceptance record's references.
  • Preserve blocks for open PRs linked to the target Issue or naming it in their title/body.
  • Keep referenced revisions, contributor credit, accepted-scope validation, source freshness, owned-branch deduplication, and durable publication-intent checks unchanged.
  • Apply the same distinction during command preparation, preflight, and final publication checks. No references are deleted or hidden to bypass the guard.

Validation

  • Reproduced the original blocker with focused regression tests before changing production logic.
  • All 93 implementation protocol/workflow tests pass on Node 24.22.1.
  • All 14 CI checks pass on the current head, including aggregate CodeQL and the isolated sandbox smoke test. The strengthened full-agreement preservation assertion also passes its focused rerun; CodeQL automatically resolved its review thread.
  • New tests cover command generation with a related open citation, successful publication preserving credit, genuine target-Issue conflicts, a reference becoming competing work, and changed referenced revisions.
  • Whitespace checks pass. No workflow YAML, runtime pins, dependencies, permissions, or credentials changed.

Operational state

The exact build command for the existing #220 acceptance was generated, but not posted or executed. The coding activation flag remains unset. This PR does not merge or close #466, accept additional work, activate spending, or start the coding pilot. Normal integration and freshness checks still require reevaluation if relevant source changes land first.

Treat citations as preserved evidence, not reservations on independent work. Keep target-Issue links and mentions, revision freshness, owned-branch checks, and publication-intent safeguards.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 2, 2026 16:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the change to how related PR citations affect accepted implementation work.

No open issues 🎉

What changed in this PR

This PR lets independently accepted implementation work proceed when its agreement cites a related open PR, while preserving checks for work competing on the target Issue.

Changes:

  • Remove citation membership alone as a blocker; retain checks for open PRs linked to or naming the target Issue.
  • Add regression coverage for related citations, preserved credit, competing work, and referenced-revision freshness.
  • Document the distinction without changing authorization or spending controls.
File Description
tools/​tests/​issue-implementation.test.mjs Add fixtures and regression tests for related citations and retained safeguards.
tools/​issue-implementation.mjs Stop treating acceptance references alone as competing contributions.
AUTOMATION.md Clarify which open PRs block accepted implementation work.

Review effort: Balanced

Verify preservation of the entire agreement instead of using a literal URL substring assertion that CodeQL misclassifies as URL sanitization.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 2, 2026 17:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change distinguishing related-PR citations from blocking PR conflicts.

No open issues 🎉

Review effort: Balanced

@robgruen
robgruen merged commit 8350fbc into main Nov 2, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants