Repository navigation
Serialize Pages deployments and isolate retry artifacts - #512
Merged
Merged
Conversation
Queue Pages publishes without cancelling an active deployment. Match upload and deployment to an attempt-specific artifact name so retained earlier attempts cannot make selection ambiguous. Add regression tests and operator recovery guidance without changing permissions or action pins. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the changes addressing Pages deployment collisions and retry artifact selection.
No open issues 🎉
What changed in this PR
This PR addresses Pages deployment collisions and ambiguous artifact selection on retries, while preserving the existing trigger, permissions, action pins, and build steps.
Changes:
- Serializes deployments in the shared
pagesconcurrency group without cancelling an active publish. - Uses matching attempt-specific names for uploaded and deployed artifacts.
- Adds focused regression tests and operator guidance for safe retries.
| File | Description |
|---|---|
tools/tests/pages-workflow.test.mjs |
Tests concurrency, retry artifact isolation, and preserved workflow safeguards. |
OWNER-CHEATSHEET.md |
Documents deployment behavior and safe retries using the original workflow version. |
.github/workflows/github-pages.yml |
Adds deployment concurrency and matching attempt-specific artifact names. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the two Pages deployment failures observed after the recent merges:
github-pagesand refused ambiguous selection.Changes
pagesconcurrency group without cancelling an active publish.github-pages-${{ github.run_attempt }}artifact. Artifact lookup is scoped to the current workflow run, and retained earlier attempts have distinct names.Permissions, the main-only trigger, action pins, Node selection, and the site build commands are unchanged. No artifact deletion or coding-pilot activation is introduced.
Validation
Rollout
The updated documentation is already live from the preceding successful deployment. After this PR is reviewed and merged, follow the new default-branch Pages run; rerunning the old failure would still use its old workflow definition. The existing failed run and its artifacts have been preserved. No automatic merge or further coding/detection run is requested.