Repository navigation
Add public proposal rounds and versioned development commands - #520
Conversation
Post iterative public recommendations and accept/build exact proposal versions without manual artifact or hash lookup. Preserve legacy commands, owner authorization, scanning, and publication safeguards. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
A writer-only recovery can publish an acceptance-enabled proposal using a failed attempt’s seal, but acceptance then rejects it; this path needs a fix and regression coverage through acceptance.
1 open issue
What changed in this PR
Adds public, versioned proposals to TypeChat’s owner-controlled automation, allowing discussion, acceptance, and separately authorized builds without manual artifact or hash lookup. The new paths remain pending live verification, and build activation stays default-off.
Changes:
- Adds
/typechat propose,/typechat accept P<number>, and/typechat build P<number>while retaining legacy commands. - Extends validation, publication safeguards, and regression coverage for public proposal rounds.
- Updates workflow prompts, generated locks, and owner/contributor documentation.
| File | Description |
|---|---|
tools/tests/issue-implementation.test.mjs |
Tests version-selected builds and immutable accepted terms. |
tools/tests/discussion-workflows.test.mjs |
Tests Issue-only proposal routing and publication guards. |
tools/tests/discussion-draft.test.mjs |
Covers proposal rounds, acceptance, freshness, and duplicate protection. |
tools/issue-implementation.mjs |
Resolves public versions to exact accepted work. |
tools/discussion-draft.mjs |
Implements proposal rendering, versioning, and acceptance verification. |
README.md |
Introduces the public proposal flow and rollout status. |
OWNER-CHEATSHEET.md |
Documents version-based commands and recovery guidance. |
AUTOMATION.md |
Defines proposal rounds, safeguards, and rollout boundaries. |
.github/workflows/issue-implementation.md |
Updates the workflow description for public-version builds. |
.github/workflows/issue-implementation.lock.yml |
Regenerates implementation workflow metadata and descriptions. |
.github/workflows/discussion-draft.md |
Adds proposal routing, scan handling, and generation instructions. |
.github/workflows/discussion-draft.lock.yml |
Regenerates proposal-enabled workflow configuration. |
.github/copilot-instructions.md |
Aligns contributor guidance with public proposal rounds. |
Review effort: Balanced
Keep original producer verification strict instead of advertising acceptance after a writer-only recovery of a failed seal. Cover fresh proposal recovery through acceptance and preserve advisory reply/proposal recovery; document the supported recovery path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved proposal writes can be missed when the original command comment is edited or deleted, allowing a new round to reuse P1 while the earlier write remains unresolved.
1 open issue
1 resolved since last review
Review effort: Balanced
Key pending proposal writes by immutable repository and Issue Node IDs plus the public version instead of rescanning mutable command comments. Retain the original command snapshot, block edited/deleted-command bypasses, and permit confirmed history to advance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
3 open issues
This comparison is brittle because it depends on fixed section indices (slice(2, 6)) and exact… · New The validation now allowspropose, but the error message still says “draft or reply”. Update the… · New Status eligibility now recognizes/typechat propose, but this rejection reason still only… · New
1 resolved since last review
Review effort: Lite
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Changes to the proposal-to-acceptance protocol and privileged build authorization remain unverified in live workflows, requiring owner review and controlled verification before rollout.
1 open issue
2 resolved since last review
Review effort: Balanced
Pass already-parsed accepted terms to visible proposal verification, extract fields by heading, and share the existing Markdown decoder. Preserve canonical record and integrity validation while covering formatting changes, semantic differences, and ambiguous or hidden fields. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Authorization-critical publication and owner-acceptance paths still await controlled owner-commanded end-to-end verification and human review of GitHub Actions permissions, handoffs, and recovery behavior.
No open issues 🎉
1 resolved since last review
Review effort: Balanced


Summary
Make the normal owner workflow public and discussion-driven, without manual artifact-ID or hash lookup:
/typechat replyfor one checked conversational response./typechat proposefor numbered public Issue proposals that consider the complete frozen discussion and previous rounds, recommend a concrete approach, and explain what changed./typechat accept P<number>to approve an exact ready public version, then separately authorize/typechat build P<number>against its immutable accepted terms.Validation
Validated after incorporating current main, including #515:
Regression coverage includes repeated public rounds, full discussion context, exact-version acceptance despite newer proposals, immutable visible terms, edited/stale/expired/ambiguous evidence, publication races, duplicate writes, legacy compatibility, and an accepted-version-to-PR lifecycle.
Rollout
The new public-proposal/version-selector paths are not yet live-verified. Controlled owner-commanded verification follows merge. This change does not enable
TYPECHAT_IMPLEMENTATION_ENABLED, start a coding run, automatically accept work, or approve merging.