Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
248bfdf
Make checker results independent of check and query order
jakebailey Nov 9, 2026
d92a57b
Do not report nonexistent properties where errors are never shown
jakebailey Nov 9, 2026
59d54ee
Do not blame a use for the circular constraint of a declaration
jakebailey Oct 22, 2026
a831b9a
Resolve mapped type constraints whenever the mapped type is requested
jakebailey Oct 22, 2026
99888b4
Resolve return type cycles as if entered at their first member
jakebailey Nov 1, 2026
97ea5c3
Use JSDoc type tags when assigning contextual parameter types
jakebailey Nov 1, 2026
e903310
Name an instantiation cycle from its first declared type
jakebailey Nov 1, 2026
08449c7
Discard results computed from a binding pattern's own elements
jakebailey Nov 2, 2026
cbe0384
Keep the result of a resolution nested in a hidden one of itself
jakebailey Nov 1, 2026
d931867
Keep results a cycle yield computes from scratch
jakebailey Nov 2, 2026
5e08332
Record per-node check facts eagerly instead of as effects
jakebailey Nov 5, 2026
5f613a1
Clear a call's resolving marker when discarding its preemptive result
jakebailey Nov 7, 2026
17246a5
Discard results cached by signature help
jakebailey Nov 7, 2026
a1625bc
Check that checkers are at rest between requests
jakebailey Nov 8, 2026
f9a988d
Hold a check's effects during variance cycles instead of recording them
jakebailey Nov 10, 2026
8a40fe5
Count computations in progress instead of indexing them
jakebailey Nov 10, 2026
eb9fe00
Track memo map entries in progress with the other computations
jakebailey Nov 10, 2026
936558d
Remove an unused memo map accessor
jakebailey Nov 11, 2026
8f3273b
Keep finding and marking computations in progress cheap when deeply n…
jakebailey Nov 12, 2026
67374cd
Stop only runaway instantiations at the limit on the instantiation stack
jakebailey Nov 12, 2026
218b174
Let a cycle yielding to a member table see the table's computation
jakebailey Nov 12, 2026
bcacd2e
Only fail a cycle yield on reading a published member table
jakebailey Nov 12, 2026
403c69a
Do not suggest typeof for a name used in its own value's declaration
jakebailey Nov 12, 2026
595cff4
Fail only one computation's instantiations at the stack limit
jakebailey Nov 13, 2026
9a2e423
Share heights and key hashing between memoized computations
jakebailey Nov 13, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/typescript/enums/objectFlags.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ export declare enum ObjectFlags {
ContainsSpread = 1 << 22,
ObjectRestType = 1 << 23,
IsClassInstanceClone = 1 << 26,
IdenticalBaseTypeCalculated = 1 << 27,
IdenticalBaseTypeExists = 1 << 28,
IsGenericTypeComputed = 1 << 22,
IsGenericObjectType = 1 << 23,
Expand Down
1 change: 0 additions & 1 deletion packages/typescript/enums/objectFlags.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ export var ObjectFlags;
ObjectFlags[ObjectFlags["ContainsSpread"] = 4194304] = "ContainsSpread";
ObjectFlags[ObjectFlags["ObjectRestType"] = 8388608] = "ObjectRestType";
ObjectFlags[ObjectFlags["IsClassInstanceClone"] = 67108864] = "IsClassInstanceClone";
ObjectFlags[ObjectFlags["IdenticalBaseTypeCalculated"] = 134217728] = "IdenticalBaseTypeCalculated";
ObjectFlags[ObjectFlags["IdenticalBaseTypeExists"] = 268435456] = "IdenticalBaseTypeExists";
ObjectFlags[ObjectFlags["IsGenericTypeComputed"] = 4194304] = "IsGenericTypeComputed";
ObjectFlags[ObjectFlags["IsGenericObjectType"] = 8388608] = "IsGenericObjectType";
Expand Down
1 change: 0 additions & 1 deletion tsc/internal/api/enum_values_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 30 additions & 10 deletions tsc/internal/api/session.go
Original file line number Diff line number Diff line change
Expand Up @@ -340,12 +340,10 @@ func (sd *snapshotData) newTypeResponse(projectID project.Handle, t *checker.Typ
resp.AliasSymbol = newSymbolReference(t.Alias().Symbol())
}
if t.ObjectFlags()&checker.ObjectFlagsMapped != 0 {
mapped := t.AsMappedType()
mapped.ResolveComponents(c, t)
resp.TypeParameter = sd.registerType(projectID, mapped.TypeParameter())
resp.ConstraintType = sd.registerType(projectID, mapped.ConstraintType())
resp.NameType = sd.registerType(projectID, mapped.NameType())
resp.TemplateType = sd.registerType(projectID, mapped.TemplateType())
resp.TypeParameter = sd.registerType(projectID, c.GetTypeParameterOfMappedType(t))
resp.ConstraintType = sd.registerType(projectID, c.GetConstraintTypeOfMappedType(t))
resp.NameType = sd.registerType(projectID, c.GetNameTypeOfMappedType(t))
resp.TemplateType = sd.registerType(projectID, c.GetTemplateTypeOfMappedType(t))
}
if checker.IsTupleTypeTarget(t) {
elementInfos := t.AsTupleType().ElementInfos()
Expand Down Expand Up @@ -3271,20 +3269,20 @@ func (s *Session) handleGetConstraintOfType(ctx context.Context, params *GetType
}

func (s *Session) handleGetTypeParameterOfMappedType(ctx context.Context, params *GetTypePropertyParams) (*TypeResponse, error) {
return s.resolveTypePropertyOfType(ctx, params, func(t *checker.Type) *checker.Type { return t.AsMappedType().TypeParameter() })
return s.resolveTypePropertyOfTypeWithChecker(ctx, params, (*checker.Checker).GetTypeParameterOfMappedType)
}

func (s *Session) handleGetConstraintTypeOfMappedType(ctx context.Context, params *GetTypePropertyParams) (*TypeResponse, error) {
return s.resolveTypePropertyOfType(ctx, params, func(t *checker.Type) *checker.Type { return t.AsMappedType().ConstraintType() })
return s.resolveTypePropertyOfTypeWithChecker(ctx, params, (*checker.Checker).GetConstraintTypeOfMappedType)
}

// @gen-proto-nullable
func (s *Session) handleGetNameTypeOfMappedType(ctx context.Context, params *GetTypePropertyParams) (*TypeResponse, error) {
return s.resolveTypePropertyOfType(ctx, params, func(t *checker.Type) *checker.Type { return t.AsMappedType().NameType() })
return s.resolveTypePropertyOfTypeWithChecker(ctx, params, (*checker.Checker).GetNameTypeOfMappedType)
}

func (s *Session) handleGetTemplateTypeOfMappedType(ctx context.Context, params *GetTypePropertyParams) (*TypeResponse, error) {
return s.resolveTypePropertyOfType(ctx, params, func(t *checker.Type) *checker.Type { return t.AsMappedType().TemplateType() })
return s.resolveTypePropertyOfTypeWithChecker(ctx, params, (*checker.Checker).GetTemplateTypeOfMappedType)
}

// @gen-proto-nullable
Expand Down Expand Up @@ -3465,6 +3463,28 @@ func (s *Session) resolveTypePropertyOfType(ctx context.Context, params *GetType
return setup.sd.newTypeResponse(setup.projectID, result, setup.checker), nil
}

// resolveTypePropertyOfTypeWithChecker is resolveTypePropertyOfType for a
// property the checker computes.
func (s *Session) resolveTypePropertyOfTypeWithChecker(ctx context.Context, params *GetTypePropertyParams, getter func(*checker.Checker, *checker.Type) *checker.Type) (*TypeResponse, error) {
setup, err := s.setupChecker(ctx, params.Snapshot, params.Project)
if err != nil {
return nil, err
}
defer setup.done()

t, err := setup.sd.resolveTypeHandle(params.Project, params.Type)
if err != nil {
return nil, err
}

result := getter(setup.checker, t)
if result == nil {
return nil, nil
}

return setup.sd.newTypeResponse(setup.projectID, result, setup.checker), nil
}

// resolveTypeArrayPropertyOfType resolves a type property of an array of types and returns an array of type responses.
func (s *Session) resolveTypeArrayPropertyOfType(ctx context.Context, params *GetTypePropertyParams, getter func(*checker.Type) []*checker.Type) ([]*TypeResponse, error) {
setup, err := s.setupChecker(ctx, params.Snapshot, params.Project)
Expand Down
5 changes: 5 additions & 0 deletions tsc/internal/ast/symbol.go
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,11 @@ func (m *SymbolMap) SymbolAt(i int) *Symbol {
return symbol
}

// At returns the name and symbol of the i-th entry, in insertion order.
func (m *SymbolMap) At(i int) (string, *Symbol) {
return m.KeyAt(i), m.SymbolAt(i)
}

func (m *SymbolMap) Find(key string) int {
if m == nil {
return -1
Expand Down
10 changes: 10 additions & 0 deletions tsc/internal/ast/utilities.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,16 @@ func GetNodeId(node *Node) NodeId {
return NodeId(id)
}

// PeekNodeId returns the id of node, or 0 if it has none yet.
func PeekNodeId(node *Node) NodeId {
return NodeId(node.id.Load())
}

// PeekSymbolId returns the id of symbol, or 0 if it has none yet.
func PeekSymbolId(symbol *Symbol) SymbolId {
return SymbolId(symbol.id.Load())
}

func GetSymbolId(symbol *Symbol) SymbolId {
id := symbol.id.Load()
if id == 0 {
Expand Down
Loading
Loading