Repository navigation
Remove GetProjectReferenceFromSource from printer.EmitHost - #65522
Open
刘亦达 (zhengdaodeguL) wants to merge 1 commit into
Open
刘亦达 (zhengdaodeguL) wants to merge 1 commit into
刘亦达 (zhengdaodeguL) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65521
Importing
tsc/internal/printerpulled intsoptions, content-mapper support, and Windows IPC (github.com/Microsoft/go-winio) throughGetProjectReferenceFromSourceonprinter.EmitHost. Go consumers that vendor the native printer on a case-insensitive filesystem could seego mod vendorcollapse theMicrosoft(go-winio) andmicrosoft(TypeScript) directories into one spelling, breaking a subsequent Linux checkout.This PR removes the method from the narrower
printer.EmitHostinterface and drops the now-unusedtsoptionsimport:compiler.EmitHoststill provides the method throughDeclarationEmitHost, and the concreteemitHostimplementation is untouched.printer.EmitHost(compiler.getScriptTransformers) does not call this method.Verification:
GOOS=windows GOARCH=amd64 go -C tsc list -deps ./internal/printerno longer containsgithub.com/Microsoft/go-winio,tsc/internal/contentmapper, ortsc/internal/tsoptions(all present on base).go -C tsc test ./internal/printer ./internal/compilerpasses.GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go -C tsc build ./cmd/tscpasses.Credit to Arnav Dugar (@arnavdugar) for the diagnosis, the verification command, and the two-line patch in #65521, applied here as published.