Repository navigation
Remove the compiler options dependency from the printer - #65523
Merged
Jake Bailey (jakebailey) merged 1 commit intoNov 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change removing the printer’s indirect compiler-options dependency.
No open issues 🎉
What changed in this PR
Decouples the native printer from compiler options, addressing #65521 by removing an indirect Windows IPC dependency that can cause vendoring failures on case-insensitive filesystems.
Changes:
- Removes the redundant
GetProjectReferenceFromSourcemethod fromprinter.EmitHostand itstsoptionsimport. - Preserves the full compiler’s access to the method through
DeclarationEmitHost.
| File | Description |
|---|---|
tsc/internal/printer/emithost.go |
Narrows the printer host interface and removes the compiler-options dependency. |
Review effort: Balanced
Jake Bailey (jakebailey)
approved these changes
Nov 16, 2026
Jake Bailey (jakebailey)
left a comment
Member
There was a problem hiding this comment.
It's really dumb that vendoring doesn't use the same escaping scheme as the module cache, and it's also dumb that this is the fix, extremely brittle, but it is a cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing the native printer pulls in compiler project options and Windows IPC through
GetProjectReferenceFromSourceonprinter.EmitHost. On case-insensitive filesystems, Go vendoring can fold themicrosoftandMicrosoftdirectories into one, causing a later Linux build to miss the TypeScript imports.Remove the redundant method and its import from the printer. The full compiler still inherits the method through
DeclarationEmitHost, and the printer can be imported without pulling in Windows IPC.Fixes #65521. The issue is awaiting Backlog triage.
Validation
./internal/printerno longer includesgo-winio.hereby test:tsc,hereby test:api,hereby lint, andhereby tidypassed. The changed file passed formatting checks.go-winiostill included.AI disclosure: Codex authored the patch and ran the validation.