Repository navigation
Python: Point multimodal and declarative MCP samples at FOUNDRY_* settings - #10082
Draft
Naveen Chatlapalli (1aifanatic) wants to merge 1 commit into
Conversation
…tings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Naveen Chatlapalli (1aifanatic)
temporarily deployed
to
github-app-auth
November 4, 2026 05:37 — with
GitHub Actions
Inactive
Naveen Chatlapalli (1aifanatic)
temporarily deployed
to
github-app-auth
November 4, 2026 05:37 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the documentation updates clarifying Foundry client settings and authentication guidance.
No open issues 🎉
What changed in this PR
Corrects Python sample documentation to match the settings read by Foundry clients, extending the cleanup in #9759. Changes are limited to documentation, comments, and a docstring; runtime behavior is unchanged.
Changes:
- Document
FOUNDRY_PROJECT_ENDPOINTandFOUNDRY_MODELfor Azure multimodal samples. - Remove unused Azure OpenAI settings and unsupported
api_keyauthentication guidance. - Correct the endpoint variable named in the declarative MCP sample.
| File | Description |
|---|---|
python/samples/02-agents/multimodal_input/README.md |
Corrects Foundry settings and authentication guidance. |
python/samples/02-agents/multimodal_input/azure_responses_multimodal.py |
Corrects the endpoint variable in setup comments. |
python/samples/02-agents/multimodal_input/azure_chat_multimodal.py |
Corrects the endpoint variable in setup comments. |
python/samples/02-agents/declarative/mcp_tool_yaml.py |
Corrects the endpoint variable in prerequisites and run instructions. |
Review effort: Balanced
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Two sample folders document settings their code doesn't read:
02-agents/multimodal_input: the Azure examples useFoundryChatClient(credential=AzureCliCredential()), which readsFOUNDRY_PROJECT_ENDPOINTandFOUNDRY_MODEL. The README listsAZURE_OPENAI_ENDPOINT,AZURE_OPENAI_MODEL(twice),AZURE_OPENAI_API_VERSIONandAZURE_OPENAI_API_KEY. The two files' comments say "Requires AZURE_OPENAI_ENDPOINT and FOUNDRY_MODEL". The README also suggests anapi_keyparameter, whichFoundryChatClientdoesn't have.02-agents/declarative/mcp_tool_yaml.py: the Foundry example tells you to setPROJECT_ENDPOINT. Theprovider: Foundryagent readsFOUNDRY_PROJECT_ENDPOINT.If you follow either set of instructions, the client fails with
ValueError: Either 'project_endpoint' or 'project_client' is required. Set project_endpoint via parameter or 'FOUNDRY_PROJECT_ENDPOINT' environment variable.Description & Review Guide
FOUNDRY_PROJECT_ENDPOINTandFOUNDRY_MODEL. The Azure OpenAI version and key settings, which this client doesn't use, are removed.FOUNDRY_PROJECT_ENDPOINT.Checked by creating each client with only the documented variables set. The old ones fail with the error above. With the new ones,
FoundryChatClientis created withmodel == "gpt-4o", and the declarative factory gets past the endpoint check.Related Issue
N/A - trivial change: sample documentation is corrected to the environment variables the code reads.
AI Assistance
AI assistance details: Claude Code helped find the mismatches by comparing sample docs with the settings the clients read, make the change, verify both settings sets, and draft this description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.🤖 Generated with Claude Code