Repository navigation
Python: Escape test-name pipes in integration trend reports - #9692
Closed
LI (ktz03) wants to merge 1 commit into
Closed
LI (ktz03) wants to merge 1 commit into
LI (ktz03) wants to merge 1 commit into
Conversation
LI (ktz03)
requested review from
SergeyMenshykh,
Tao Chen (TaoChenOSU),
Vincent Biret (baywet),
Eduard van Valkenburg (eavanvalkenburg),
Giles Odigwe (giles17),
Jose Alvarez (jpalvarezl),
Evan Mattson (moonbox3),
Peter Ibekwe (peibekwe),
Roger Barreto (rogerbarreto),
sophia-ramsey and
westey (westey-m)
as code owners
October 26, 2026 02:22
LI (ktz03)
temporarily deployed
to
github-app-auth
October 26, 2026 02:22 — with
GitHub Actions
Inactive
LI (ktz03)
temporarily deployed
to
github-app-auth
October 26, 2026 02:22 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized display-only fix has focused regression coverage and no identified blocking issues; tests were not executed during this review.
No open issues 🎉
What changed in this PR
This PR fixes Markdown table alignment in integration trend reports by escaping pipes in displayed test names without changing stored identifiers or report data.
Changes:
- Escape pipes in short test names for Python and per-framework report tables.
- Add six regression tests covering formatting, unchanged history, and CLI output.
- Run the regression tests in the existing Python Code Quality workflow.
| File | Description |
|---|---|
python/scripts/integration_test_report/tests/test_trend_table.py |
Adds six formatting and data-preservation regression tests. |
python/scripts/integration_test_report/aggregate.py |
Escapes pipes in displayed short test names. |
.github/workflows/python-code-quality.yml |
Runs the new tests through unittest discovery. |
Review effort: Balanced
4 of 7 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
A pytest parameter ID such as
a|bis written unescaped inside the integration trend report's test-name cell. GitHub Flavored Markdown treats the pipe as a column separator even inside a code span, so the displayed test name is split and the file, provider and result columns shift.Description & Review Guide
Related Issue
N/A - trivial change. This corrects text escaping required by the existing table format (GFM tables, Example 200); it does not alter report data or introduce a new reporting policy.
AI Assistance
AI assistance details: Codex: implementation, regression tests, and this PR description.
Contribution Checklist