Repository navigation
Python: Correct multimodal sample setup variables - #9735
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
Conversation
AI-assisted with OpenAI Codex.
|
/review |
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): 37971e90165c
Model: gpt-5.6-sol
Overview
This documentation-only change aligns the multimodal samples with the environment variables that FoundryChatClient actually resolves. The full project-scoped endpoint follows the repository's sample guidance, and constructor checks plus settings tests confirm that both documented variables are required. No publishable risk was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
|
BlueRaddish The authentication guidance still recommends passing an |
Motivation & Context
The multimodal guide currently tells readers to configure Azure OpenAI variables, but both Azure-named scripts construct
FoundryChatClientand require the Foundry project endpoint and model variables. Following the documented configuration raisesValueError: Model is requiredbefore either example can run.Description & Review Guide
FOUNDRY_PROJECT_ENDPOINTandFOUNDRY_MODEL, including a full project-scoped endpoint example.azure_chat_multimodal.pyandazure_responses_multimodal.py. Both unchanged completemain()paths were exercised with real Foundry client construction and an offline response boundary: the original instructions fail twice, two explicit-configuration controls pass, and all four cases pass with the guide corrected. Normal scoped and native hooks pass, including whole-samples checks; nine hooks are nonapplicable. No live Azure credentials, network/model responses, full workspace unit suite or distribution build are claimed.Related Issue
N/A - trivial change. This is an obvious documentation correction to the environment variable names already required by the two adjacent sample scripts; the intended configuration is not in dispute.
AI Assistance
AI assistance details: OpenAI Codex assisted with identifying the documentation mismatch, the focused documentation change, offline verification and this description.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.