[Dhruv Shaswat (Dhruv-Sh-git)]

Fixes #9784.

Summary

Passing tools returned by FoundryChatClient.get_bing_custom_search_tool() or FoundryChatClient.get_code_interpreter_tool() directly to an agent or _prepare_tools_for_openai() could fail during JSON serialization with a TypeError.
The issue was that _sanitize_foundry_response_tool() only made a shallow copy of the tool mapping. Nested Azure SDK models were left unchanged, so they couldn't be serialized as JSON.

Changes

• Updated _tools.py to recursively convert nested SDK models into plain Python data using their .as_dict() representation, including values inside mappings and sequences.
• Added regression tests in test_foundry_chat_client.py for both Bing custom search and code interpreter tools, checking that they produce valid JSON payloads through _prepare_tools_for_openai().

Testing

Validated locally with Ruff and pytest: 464 tests passed in packages/foundry.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[Eduard van Valkenburg (eavanvalkenburg)]

/review

[github-actions]

MAF Automated Review — Iteration 1

Result: Findings reported
Scope: full PR (1 commit(s)): f2ebec8206d3
Model: gpt-5.6-sol

Overview

The change fixes the reported serialization failure by recursively converting nested Azure SDK models, and the new tests exercise both affected factories through the real preparation path and json.dumps(). Existing validation, field stripping, and explicit container preservation remain intact. However, checking for as_dict before handling mappings introduces a compatibility regression for otherwise valid mapping-based hosted tools.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
1 verified finding remained after source verification (1 medium) across 1 file. Details are attached to the affected lines below.

Affected areas: python/packages/foundry/agent_framework_foundry/_tools.py

[Eduard van Valkenburg (eavanvalkenburg)]

Thanks for the fix, Dhruv Shaswat (@Dhruv-Sh-git). The Azure SDK tool model already provides the canonical recursive conversion through as_dict(), and the issue confirms that path produces the correct JSON-safe payload. Rather than maintaining a generic recursive hasattr(as_dict) converter in Agent Framework, please use the SDK’s canonical conversion for recognized Azure SDK tool models at the hosted-tool boundary, then apply the existing sanitization to the resulting plain mapping. Keep arbitrary caller-supplied Mapping objects on normal mapping semantics, and retain regressions for Bing Custom Search, code interpreter, and mappings with unrelated or incompatible as_dict methods.