Skip to content

Python: fix typos and missing space in sample prompt - #9856

Open
kylin (JennyMa11) wants to merge 1 commit into
microsoft:mainfrom
JennyMa11:docs/fix-sample-typos
Open

kylin (JennyMa11) wants to merge 1 commit into
microsoft:mainfrom
JennyMa11:docs/fix-sample-typos

Conversation

@JennyMa11

Copy link
Copy Markdown

Motivation & Context

The group-chat selector sample builds its agent instructions from adjacent string
literals, and the first literal has no trailing space, so the model receives
"practically dangerous.If there is nothing woth pointing out". Two other samples
carry wording mistakes: "gracefull" in the tool-recovery sample and a doubled
"with" in the message it prints, plus "messsages ... nor load" in a comment in the
Foundry memory sample.

Description & Review Guide

  • What are the major changes? Correct the missing space and the typo in the
    selector prompt; fix "gracefull" and "Tool failed: with error" in the tool
    recovery sample and update its Expected Output block to match; fix the wording
    and spelling of a comment in the Foundry memory sample.
  • What is the impact of these changes? Samples only. No library code, no API,
    no behavior change. The only non-cosmetic element is the missing space inside
    the concatenated prompt string.
  • What do you want reviewers to focus on? Whether the reworded prompt clause in
    the selector sample is acceptable as written.

Related Issue

N/A - trivial change: spelling and grammar fixes in samples. The one-character
prompt fix restores the intended sentence boundary; nothing else changes behavior.

AI Assistance

  • This is an AI-assisted contribution. I reviewed, understood, and verified all submitted content and accept responsibility for it.

AI assistance details: A coding agent located the misspellings with a spell checker
and flagged the missing space while reviewing the diff. I reviewed each change and
verified the files compile and pass the repository's spell and lint checks. No
library code was generated.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR links to an agreed issue with no competing open PR, or the Related Issue section documents a trivial-change or repository-automation exception.
  • This is not a breaking change.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@agent-framework-automation agent-framework-automation Bot added the python Usage: [Issues, PRs], Target: Python label Oct 30, 2026
@JennyMa11

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@eavanvalkenburg

Copy link
Copy Markdown
Member

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: No findings
Scope: full PR (1 commit(s)): 776c73e22e31
Model: gpt-5.6-sol

Overview

This sample-only change corrects spelling and output text while restoring the missing sentence boundary in the verifier prompt. The tool exception behavior and expected-output example remain synchronized, and the changed code introduces no API, persistence, authorization, or resource-lifecycle surface. No Critical, High, or Medium defect was established.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

@agent-framework-automation

Copy link
Copy Markdown

kylin (@JennyMa11), this pull request is waiting on your response. If there is no further activity within 4 days, it will be closed automatically. (This is an automated message.)

@agent-framework-automation agent-framework-automation Bot added the requested-info Information or updates are needed from the author; inactive PRs may be closed automatically. label Nov 4, 2026

This branch was successfully deployed

No deployments
github-app-auth — 776c73e2 Deployed Oct 30, 2026 by JennyMa11 via team_check #8052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Usage: [Issues, PRs], Target: Python requested-info Information or updates are needed from the author; inactive PRs may be closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants