Repository navigation
Python: give each file memory its own description sidecar - #9872
Closed
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Closed
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
The sidecar name stripped the file extension, so notes.md and notes shared one sidecar and one file's description overwrote or deleted the other's. The suffix now appends to the full name, sidecars written under the previous name are still read through a fallback, and writes and deletes retire both spellings. Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Manohar Paturi (ManoharPaturi)
requested review from
SergeyMenshykh and
Eduard van Valkenburg (eavanvalkenburg)
as code owners
October 30, 2026 04:32
Manohar Paturi (ManoharPaturi)
temporarily deployed
to
github-app-auth
October 30, 2026 04:32 — with
GitHub Actions
Inactive
Manohar Paturi (ManoharPaturi)
temporarily deployed
to
github-app-auth
October 30, 2026 04:32 — with
GitHub Actions
Inactive
Contributor
Author
|
Sorry for skipping the review step. #9871 now uses the bug report template with the sidecar reproduction, and this stays closed until the team agrees. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
The description sidecar name stripped a file's extension before appending the suffix, so
notes.mdandnotesshared one sidecar. Writing either file's description overwrote the other's, rewriting one without a description deleted the other's description, and deleting either file removed both. The mapping from memory files to their sidecars needs to be injective.Description & Review Guide
notes.mdgetsnotes.md_description.mdwhile extension-less names keep their existingname_description.mdsidecar. Reads fall back to the legacy stripped name so descriptions written by earlier versions keep feeding the index, and writes and deletes retire both spellings so a legacy sidecar can never resurrect stale text.Related Issue
Fixes #9871
AI Assistance
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.