Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python: Harden FIDES service history continuation #9877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Harden FIDES service history continuation #9877
Changes from all commits
e05b026b04ad3b85a6ad14d7c69cFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placing history persistence before all provider middleware makes it snapshot
context.messagesbefore downstream middleware can filter or replace the request. The leaf client receives the filtered messages, butHistoryProvider.after_runpersists the earlier snapshot, so content deliberately removed before dispatch can still be written durably and downstream additions are omitted. Preserve the early history load needed by FIDES, but capture the messages to persist after provider request middleware has finalized the outbound request.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For local per-service-call history, this preload invokes each loadable provider here and the history middleware invokes
before_runagain for the first model call. CustomHistoryProvider.before_runis explicitly supported and may advance a cursor, consume records, mutate state, or return a different snapshot, so FIDES can authorize one transcript while the model receives another. Reuse this loaded snapshot for the first service call, then reload only for later function-loop calls.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.