[lisry-1]

Summary

Mem0ContextProvider.after_run forwards user_id and agent_id to the OSS AsyncMemory client as unconditional direct kwargs, even though _validate_filters permits configuring only one of them. When a user configures only user_id (so agent_id is None), add() receives agent_id=None and the run crashes after the model has already produced a reply.

Problem

The two client paths are asymmetric for the same identity configuration:

• Platform path (_build_filters) only includes non-empty fields:

  if self.user_id:   filters["user_id"] = self.user_id
  
  if self.agent_id:  filters["agent_id"] = self.agent_id
  
  if self.application_id: filters["app_id"] = self.application_id

• OSS path writes both unconditionally:

  add_kwargs["user_id"] = self.user_id      # may be None
  
  add_kwargs["agent_id"] = self.agent_id    # may be None

_validate_filters explicitly allows a single identity field ("At least one of the filters: agent_id, user_id, or application_id"), so a user_id-only configuration is valid — yet it passes agent_id=None to the OSS SDK's required str parameter and fails after the reply was generated (after_run is awaited with no try/except upstream).

Changes

Make the OSS branch conditional, matching _build_filters: only include user_id / agent_id when non-empty.

Tests

Added test_oss_storage_omits_unset_identity_fields: with only user_id="u1" configured, add() receives user_id but no agent_id key and no filters dict.

[Copilot]

🟡 Changes recommended

The regression tests lack coverage for valid agent-only configurations, so restoring an unconditional user_id assignment could go undetected.

1 open issue

• Add after_run coverage for agent-only identity configuration · New

What changed in this PR

This PR updates the Python Mem0 integration to omit unset identity fields when storing memories through the OSS client, matching the Platform path’s filtering behavior.

Changes:

• Forward user_id and agent_id only when non-empty.
• Add a user-only regression test verifying that agent_id and filters are absent from OSS storage arguments.

File	Description
python/​packages/​mem0/​tests/​test_mem0_context_provider.py	Adds regression coverage for user-only OSS storage.
python/​packages/​mem0/​agent_framework_mem0/​_context_provider.py	Conditionally forwards identity fields to the OSS client.

_{Review effort: Balanced}

[Eduard van Valkenburg (eavanvalkenburg)]

Thanks for the contribution, lisry-1. The code review is clean, but the PR body still needs the required Related Issue answer before approval. Please link an agreed issue with a closing keyword, or document why this is an undisputed trivial change or repository automation. Missing AI Assistance alone is not a blocker.

[lisry-1]

Thanks Eduard van Valkenburg (@eavanvalkenburg). I've opened #9976 to track this bug and linked it in the PR's Related Issue section (Fixes #9976). This makes the OSS path consistent with _build_filters by omitting unset identity fields. Please let me know if the issue needs a ready-for-implementation label or any further confirmation before you can approve. Happy to adjust.