Repository navigation
Python: Expand optional MCP tool regression coverage - #9937
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoNov 2, 2026
Conversation
ssccinng
requested review from
SergeyMenshykh,
Eduard van Valkenburg (eavanvalkenburg),
Roger Barreto (rogerbarreto) and
westey (westey-m)
as code owners
November 1, 2026 15:51
ssccinng
temporarily deployed
to
github-app-auth
November 1, 2026 15:51 — with
GitHub Actions
Inactive
ssccinng
requested review from
Darren Cohen (dargilco),
Jose Alvarez (jpalvarezl) and
sophia-ramsey
as code owners
November 1, 2026 15:51
ssccinng
temporarily deployed
to
github-app-auth
November 1, 2026 15:51 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for this test-only expansion of optional-task MCP regression coverage.
No open issues 🎉
What changed in this PR
This PR strengthens Python MCP regression coverage for the optional-task tool behavior restored in #9746. It changes tests only, leaving production behavior unchanged.
Changes:
- Verify that optional tools forward a non-empty query argument and tool metadata and return the expected result.
- Check exact parameter mappings and confirm required-task tools remain excluded.
- Assert that only required-task tools produce a skip warning, while forbidden-task and ordinary tools remain callable.
| File | Description |
|---|---|
python/packages/core/tests/core/test_mcp.py |
Expands assertions for MCP tool discovery, argument and metadata forwarding, warnings, and successful invocation. |
Review effort: Balanced
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Nov 2, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Tools declaring optional MCP task support can also be called normally. The production fix is already in #9746; this contribution preserves additional regression coverage for arguments, metadata, and successful results.
Description & Review Guide
Supersedes #9680.
Validation coverage: the MCP tests, core package checks, all five configured core test type checkers, and workspace package checks passed with the pinned tools on Python 3.12 and Python 3.11.
Validation: The additional regression coverage passes on the current target branch. The listed validation commands passed. The same configured checks also passed with Python 3.11.
Related Issue
Fixes #9675.
AI Assistance
AI assistance details: Implementation, regression coverage, and review were AI-assisted.
Contribution Checklist