fix(guestfs-tools): disable legacy malloc checking - #18715
Draft
Tobias Brick (tobiasb-ms) wants to merge 1 commit into
Draft
fix(guestfs-tools): disable legacy malloc checking#18715Tobias Brick (tobiasb-ms) wants to merge 1 commit into
Tobias Brick (tobiasb-ms) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Tobias Brick (tobiasb-ms)
September 4, 2026 18:38
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The overlay lacks required metadata, and mandatory RPM inspection and smoke-test validation are not documented.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Disables glibc’s legacy malloc checker for guestfs-tools tests while retaining allocator perturbation and %check.
Changes:
- Adds and applies the allocator compatibility patch.
- Refreshes rendered spec release and component lock.
File summaries
| File | Description |
|---|---|
base/comps/guestfs-tools/guestfs-tools.comp.toml |
Registers the new overlay. |
base/comps/guestfs-tools/0002-tests-disable-glibc-malloc-check.patch |
Defines the source patch. |
specs/g/guestfs-tools/guestfs-tools.spec |
Adds the rendered patch reference and release bump. |
specs/g/guestfs-tools/0002-tests-disable-glibc-malloc-check.patch |
Contains the rendered patch. |
locks/guestfs-tools.lock |
Refreshes the input fingerprint. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Tobias Brick (tobiasb-ms)
September 4, 2026 18:55
View session
Remove the checked allocator because it splits SymCrypt allocations across libc and malloc-debug. Retain malloc perturbation and the full test suite, and classify the overlay as an AZL-only workaround. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Tobias Brick (tobiasb-ms)
force-pushed
the
tobiasb-ms/bug-23502-guestfs-tools
branch
from
September 4, 2026 18:56
583a509 to
0991897
Compare
Copilot started reviewing on behalf of
Tobias Brick (tobiasb-ms)
September 4, 2026 18:58
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted workaround is synchronized across component inputs, rendered output, and lock state, with the affected %check path validated.
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Contributor
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes glibc's legacy checked allocator from the guestfs-tools test wrapper because it splits SymCrypt allocations across libc and malloc-debug. Retains malloc perturbation and the full test suite.
AB#23502
Validation: stage2-prod package build passes with
%checkenabled.