-
Notifications
You must be signed in to change notification settings - Fork 85
feat(open): add 'open vscode' and 'open ssms', remove retired 'open ads' #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dlevy-msft-sql
wants to merge
71
commits into
microsoft:main
Choose a base branch
from
dlevy-msft-sql:pr-685
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
9e8487c
feat(open): add sqlcmd open vscode and sqlcmd open ssms commands
dlevy-msft-sql 3ea2ba1
fix: handle JSONC in VS Code settings.json and use atomic write
dlevy-msft-sql 6059b67
fix: prevent TestVSCode from writing to real settings.json
dlevy-msft-sql b8e573e
fix: suppress errcheck lint for best-effort os.Remove on cleanup paths
dlevy-msft-sql 4dbd118
fix: RunWithOutput stdout conflict and clipboard security warning
dlevy-msft-sql 3ff298e
i18n: localize Linux clipboard fallback error
dlevy-msft-sql 67c9187
feat: remove sqlcmd open ads (Azure Data Studio retired)
dlevy-msft-sql d1cdf75
feat(open): launch SSMS via ssms:// URL handler with registry-based d…
dlevy-msft-sql 0cee938
revert: launch SSMS via ssms:// URL handler
dlevy-msft-sql 05adaff
feat(open): discover SSMS via vswhere and add --version flag
dlevy-msft-sql b2a8c19
feat(open): add --build flag and build-aware VS Code discovery
dlevy-msft-sql d7797bc
fix(tools): include exe name as argv[0] on Windows so first flag is n…
dlevy-msft-sql 5c30915
fix(tools): launch tools detached so sqlcmd returns immediately
dlevy-msft-sql cd52563
fix(open): connect via mssql --open-url instead of opening empty window
dlevy-msft-sql ba793b0
fix(tools): redirect gui child stdio to null device so sqlcmd exits
dlevy-msft-sql 4c600aa
feat(open): finalize vscode launch for mssql extension
dlevy-msft-sql f67fe35
fix(open): satisfy golangci-lint (errcheck, QF1007)
dlevy-msft-sql 37a308b
fix(open): return empty string when container inspect fails
dlevy-msft-sql 860c168
fix(open): use Mandatory encrypt enum and honor VSCODE_EXTENSIONS
dlevy-msft-sql 948874f
refactor(open): drop ai-slop comments and tautological clipboard tests
dlevy-msft-sql 8227754
fix(tools): launch macOS vscode via in-bundle binary not the .app dir…
dlevy-msft-sql db302a8
fix(open): pass ssms username argv raw without bogus shell-escape
dlevy-msft-sql f68cc0d
fix(open): back up settings.json when vscode comments would be lost
dlevy-msft-sql 6b52dae
refactor(open): drop dead vscode RunWithOutput and tautological tests
dlevy-msft-sql 1c6c48f
revert: keep macOS vscode searchLocations on the .app bundle
dlevy-msft-sql fc6db75
fix(open): don't claim mssql extension install succeeded when we only…
dlevy-msft-sql 4ce2b06
fix(tools): detach stdio when /dev/null open fails to avoid pipe-drai…
dlevy-msft-sql faa516e
test(open): assert full settings.json path tail per OS not just Code
dlevy-msft-sql 1dae245
refactor(open): drop --install-extension; vscode:// URL already prompts
dlevy-msft-sql 6408d01
docs: address PR feedback on open vscode/ssms
dlevy-msft-sql 92d5c8c
refactor(tools): drop unused RunWithOutput and stale --install-extens…
dlevy-msft-sql bf3720a
fix(i18n): restore translation catalog after rebase
dlevy-msft-sql 229f6e4
fix(open): drop tcp: prefix and base64-encode test password
dlevy-msft-sql 1b00afa
feat(open): platform-conditional vscode/ssms hints in help
dlevy-msft-sql 2af58cd
test(ssms): cover partial-install case; drop trivial Name() test
dlevy-msft-sql 0ecabb9
refactor(open): preserve vscode settings.json comments via hujson
dlevy-msft-sql 31ea8e5
feat(open): enable 'sqlcmd open' on linux
dlevy-msft-sql f8bbf23
refactor(root): drop tautological GOOS gate on open subcommand
dlevy-msft-sql 01fbc91
fix(open): resolve vscode settings path for snap, XDG, and missing HOME
dlevy-msft-sql 9ea4273
fix(open): scope persisted credentials and clipboard copy to the inst…
dlevy-msft-sql f9eb449
fix: address copilot review on PR #688
dlevy-msft-sql 745769d
chore: remove accidentally committed scratch files
dlevy-msft-sql 3dab1f9
fix(container): return empty string when ContainerName called with em…
dlevy-msft-sql a8c0b0a
fix(open): use platform-appropriate home-dir hint
dlevy-msft-sql 79ba062
fix: address copilot review on basic auth guard and ssms help text
dlevy-msft-sql d66954e
fix: localize home directory error and ssms_unix fatal message
dlevy-msft-sql 9520827
fix: address copilot review on argv normalization, home dir nil err, …
dlevy-msft-sql ea35c7a
refactor: hoist ssms struct and DefineCommand to untagged file
dlevy-msft-sql 4848426
fix: verify vscode install before writing settings; harden code shim …
dlevy-msft-sql 6f7b2c2
refactor: rename Ssms type to SSMS for acronym consistency
dlevy-msft-sql b876d8d
fix: detect early-exit failures in tool.Run and show SSMS install help
dlevy-msft-sql 425acbb
fix: guard copyPasswordToClipboard against nil output
dlevy-msft-sql 7787b35
test: gate COMSPEC-based tool tests to Windows
dlevy-msft-sql afae351
docs: update tool.Run stdio comment to match Wait goroutine
dlevy-msft-sql 7740e75
fix: restrict isLocalEndpoint to container-backed endpoints
dlevy-msft-sql cf60098
fix: drop redundant port field from vscode mssql profile
dlevy-msft-sql 81c200c
fix: resolve clip.exe via SystemRoot to avoid PATH hijack
dlevy-msft-sql e82dfad
fix: clean up vscode connection profile when sqlcmd delete runs
dlevy-msft-sql ff278ac
fix: harden Windows path fallbacks for clip.exe and VS Code probing
dlevy-msft-sql 9467346
fix(open): fail fast on 'open vscode' and 'open ssms' with no current…
dlevy-msft-sql dcecce0
fix(open): guard linux/darwin VS Code probes against empty HOME
dlevy-msft-sql 83ceefb
refactor: drop restate-the-code comments from open/clipboard files
dlevy-msft-sql 337881f
feat: stage password to clipboard for VS Code remote SQL auth
dlevy-msft-sql 2538c8f
test: reset shared config between open tests to make them order-indep…
dlevy-msft-sql 8fb81b9
fix: harden vscode settings dir perms, pin pbcopy path, isolate more …
dlevy-msft-sql 610feff
fix: pin linux clipboard helper to LookPath result to prevent PATH races
dlevy-msft-sql 7d10cd2
fix: suggest install options when linux clipboard helper is missing
dlevy-msft-sql 5e73234
fix: list per-WM install commands in linux clipboard error
dlevy-msft-sql af1fcf2
fix(open vscode): launch via in-bundle code CLI on macOS
dlevy-msft-sql a73f0a8
fix(config add-endpoint): don't apply locale thousands separator to port
dlevy-msft-sql 74504d7
refactor(open): trim restate-the-code and dramatic comments
dlevy-msft-sql File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.