Fix terminal color report routing - #479
Open
Misaka (chuxubank) wants to merge 1 commit into
Open
Misaka (chuxubank) wants to merge 1 commit into
Misaka (chuxubank) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Route dynamic terminal color reports (OSC 10/11/12) back to the child PTY instead of treating them as shell keypresses.
Programs such as chezmoi query the terminal background with
OSC 11;?. Inside an inshellisense session, the query reaches the host terminal, but itsOSC 11;rgb:...response currently enters readline as user input and is printed at the prompt.Changes
ISTerm, alongside the existing cursor-position query trackingValidation
npm run lintnpm test -- --runInBand— 207 passed, 10 skippednpm run buildnpm run test:e2e -- --runInBanddid not complete in the local nested inshellisense environment and was stopped after 30 minutes; the cross-platform GitHub Actions matrix should provide the authoritative E2E result.