Queryable References

[Dimitri Ratz (ratzdi)]

A proposal for #1911. Introduced Reference as new response type in the method references. Extended ReferenceParams with array of reference kinds to filter by.

[Dimitri Ratz (ratzdi)]

@microsoft-github-policy-service agree
@microsoft-github-policy-service agree [company="Dimitri Ratz"]

[Dirk Bäumer (dbaeumer)]

Dimitri Ratz (@ratzdi) besides adding something to the spec we also require a client and server implementation to prove the usefulness. Is something like this available?

[Dimitri Ratz (ratzdi)]

Hi Dirk Bäumer (@dbaeumer), not yet, but would it be enough if we implement the proposal on the server side in Clangd and on the client side in LSP4E/CDT LSP?

[Dirk Bäumer (dbaeumer)]

Yes, we don't have requirements for clients / servers.

This being said I am not a fan of the long list of reference kinds. That one is hard to maintain across different languages. A tag model would be better IMO.

[qouteall]

For the ReferenceKind thing, I think it needs to add other reference kinds:

• For field: field initialization. I think field initialization should be different to field write.
• Import
• Re-export
• For type: usage as type parameter
• For type: type alias

And there are many other language-specific things. For example in Java a type can be used in .class. In Rust there are immutable borrow usages and mutable borrow usages. I think not hardcoding all reference kinds in LSP is more extensible