fix(html): keep links inside inline code as literal text - #2435
Open
Nickita Khylkouski (nickita-khylkouski) wants to merge 1 commit into
Open
fix(html): keep links inside inline code as literal text#2435Nickita Khylkouski (nickita-khylkouski) wants to merge 1 commit into
Nickita Khylkouski (nickita-khylkouski) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey, found a small issue with linked identifiers in API docs.
<code><a href="Action.html">Action</a></code>currently comes out as[Action](Action.html)instead ofAction. The link syntax ends up inside the backticks, so it becomes part of the code. This markup also appears in OpenJDK’s JMenu docs. This adds an early return for anchors inside code, kbd, and samp, before trimming or link formatting. Regular links still work, including links wrapped around code spans. Kept this separate from #2396’s whitespace fix. These inline-code cases still fail with that PR applied, and pass with this change added. Added six regression cases and three controls: six fail before the fix, all nine pass after. Checked the real converter source locally on Python 3.13 with markdownify 1.2.2 using a source-subset import harness; I haven’t run the full Hatch suite yet. Prepared with ChatGPT assistance.